mbox series

[V8,0/4] dt: Add fdtoverlay rule and statically build unittest

Message ID cover.1613127681.git.viresh.kumar@linaro.org (mailing list archive)
Headers show
Series dt: Add fdtoverlay rule and statically build unittest | expand

Message

Viresh Kumar Feb. 12, 2021, 11:18 a.m. UTC 
Hi,

This patchset adds a generic rule for applying overlays using fdtoverlay
tool and then updates unittests to get built statically using the same.

V7->V8:
- Patch 1 is new.
- Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
  foo.dtb.
- Use multi_depend instead of .SECONDEXPANSION.
- Use dtb-y for unittest instead of overlay-y.
- Rename the commented dtb filess in unittest Makefile as .dtbo.
- Improved Makefile code (I am learning a lot every day :)

V6->V7:
- Dropped the first 4 patches, already merged.
- Patch 1/3 is new, suggested by Rob and slightly modified by me.
- Adapt Patch 3/3 to the new rule and name the overlay dtbs as .dtbo.

--
Viresh

Rob Herring (1):
  kbuild: Add generic rule to apply fdtoverlay

Viresh Kumar (3):
  kbuild: Simplify builds with CONFIG_OF_ALL_DTBS
  of: unittest: Create overlay_common.dtsi and testcases_common.dtsi
  of: unittest: Statically apply overlays using fdtoverlay

 drivers/of/unittest-data/Makefile             | 50 ++++++++++
 drivers/of/unittest-data/overlay_base.dts     | 90 +-----------------
 drivers/of/unittest-data/overlay_common.dtsi  | 91 +++++++++++++++++++
 drivers/of/unittest-data/static_base_1.dts    |  4 +
 drivers/of/unittest-data/static_base_2.dts    |  4 +
 drivers/of/unittest-data/testcases.dts        | 18 ++--
 .../of/unittest-data/testcases_common.dtsi    | 19 ++++
 .../of/unittest-data/tests-interrupts.dtsi    |  7 --
 scripts/Makefile.lib                          | 29 +++++-
 9 files changed, 200 insertions(+), 112 deletions(-)
 create mode 100644 drivers/of/unittest-data/overlay_common.dtsi
 create mode 100644 drivers/of/unittest-data/static_base_1.dts
 create mode 100644 drivers/of/unittest-data/static_base_2.dts
 create mode 100644 drivers/of/unittest-data/testcases_common.dtsi

Comments

Viresh Kumar March 1, 2021, 6:56 a.m. UTC | #1 
On 12-02-21, 16:48, Viresh Kumar wrote:
> Hi,
> 
> This patchset adds a generic rule for applying overlays using fdtoverlay
> tool and then updates unittests to get built statically using the same.
> 
> V7->V8:
> - Patch 1 is new.
> - Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
>   foo.dtb.
> - Use multi_depend instead of .SECONDEXPANSION.
> - Use dtb-y for unittest instead of overlay-y.
> - Rename the commented dtb filess in unittest Makefile as .dtbo.
> - Improved Makefile code (I am learning a lot every day :)

Ping!
Frank Rowand March 2, 2021, 3:14 a.m. UTC | #2 
Hi Viresh,

On 3/1/21 12:56 AM, Viresh Kumar wrote:
> On 12-02-21, 16:48, Viresh Kumar wrote:
>> Hi,
>>
>> This patchset adds a generic rule for applying overlays using fdtoverlay
>> tool and then updates unittests to get built statically using the same.
>>
>> V7->V8:
>> - Patch 1 is new.
>> - Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
>>   foo.dtb.
>> - Use multi_depend instead of .SECONDEXPANSION.
>> - Use dtb-y for unittest instead of overlay-y.
>> - Rename the commented dtb filess in unittest Makefile as .dtbo.
>> - Improved Makefile code (I am learning a lot every day :)
> 
> Ping!
> 

Please respin on 5.12-rc1, and pull in the change you said
you would make in response to my post v8 comment about the
v7 patches.

-Frank
Viresh Kumar March 2, 2021, 4:02 a.m. UTC | #3 
On 01-03-21, 21:14, Frank Rowand wrote:
> Hi Viresh,
> 
> On 3/1/21 12:56 AM, Viresh Kumar wrote:
> > On 12-02-21, 16:48, Viresh Kumar wrote:
> >> Hi,
> >>
> >> This patchset adds a generic rule for applying overlays using fdtoverlay
> >> tool and then updates unittests to get built statically using the same.
> >>
> >> V7->V8:
> >> - Patch 1 is new.
> >> - Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
> >>   foo.dtb.
> >> - Use multi_depend instead of .SECONDEXPANSION.
> >> - Use dtb-y for unittest instead of overlay-y.
> >> - Rename the commented dtb filess in unittest Makefile as .dtbo.
> >> - Improved Makefile code (I am learning a lot every day :)
> > 
> > Ping!
> > 
> 
> Please respin on 5.12-rc1, and pull in the change you said
> you would make in response to my post v8 comment about the
> v7 patches.

Yes, I will do that.

I must have been more explicit about the Ping I believe. It was
more for Masahiro and Rob to see if the kbuild stuff (which is
relatively new) makes sense or not before I respin this..
Rob Herring March 2, 2021, 8:17 p.m. UTC | #4 
On Mon, Mar 1, 2021 at 10:03 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 01-03-21, 21:14, Frank Rowand wrote:
> > Hi Viresh,
> >
> > On 3/1/21 12:56 AM, Viresh Kumar wrote:
> > > On 12-02-21, 16:48, Viresh Kumar wrote:
> > >> Hi,
> > >>
> > >> This patchset adds a generic rule for applying overlays using fdtoverlay
> > >> tool and then updates unittests to get built statically using the same.
> > >>
> > >> V7->V8:
> > >> - Patch 1 is new.
> > >> - Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
> > >>   foo.dtb.
> > >> - Use multi_depend instead of .SECONDEXPANSION.
> > >> - Use dtb-y for unittest instead of overlay-y.
> > >> - Rename the commented dtb filess in unittest Makefile as .dtbo.
> > >> - Improved Makefile code (I am learning a lot every day :)
> > >
> > > Ping!
> > >
> >
> > Please respin on 5.12-rc1, and pull in the change you said
> > you would make in response to my post v8 comment about the
> > v7 patches.
>
> Yes, I will do that.
>
> I must have been more explicit about the Ping I believe. It was
> more for Masahiro and Rob to see if the kbuild stuff (which is
> relatively new) makes sense or not before I respin this..

LGTM, I was mainly waiting on Acks from Masahiro and Frank.

Rob