| Message ID | 20210302011640.1276636-1-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | iwlwifi: fix ARCH=i386 compilation warnings | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > warnings found with v5.12-rc1 and next-20210301 Luca, can I take this to wireless-drivers?
On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote: > Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes: > > > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > --- > > warnings found with v5.12-rc1 and next-20210301 > > Luca, can I take this to wireless-drivers? Yes, please. Acked-by: Luca Coelho <luciano.coelho@intel.com> -- Cheers, Luca.
"Coelho, Luciano" <luciano.coelho@intel.com> writes: > On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote: >> Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes: >> >> > An unsigned long variable should rely on '%lu' format strings, not '%zd' >> > >> > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") >> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> > --- >> > warnings found with v5.12-rc1 and next-20210301 >> >> Luca, can I take this to wireless-drivers? > > Yes, please. > > Acked-by: Luca Coelho <luciano.coelho@intel.com> Thansk. I don't see this in patchwork yet (I guess vger is slow again) so I cannot assign it to me at the moment, will do it later.
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Acked-by: Luca Coelho <luciano.coelho@intel.com> Patch applied to wireless-drivers.git, thanks. 436b265671d6 iwlwifi: fix ARCH=i386 compilation warnings
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c index fd070ca5e517..40f2109a097f 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c @@ -271,12 +271,12 @@ static int iwl_pnvm_get_from_efi(struct iwl_trans *trans, err = efivar_entry_get(pnvm_efivar, NULL, &package_size, package); if (err) { IWL_DEBUG_FW(trans, - "PNVM UEFI variable not found %d (len %zd)\n", + "PNVM UEFI variable not found %d (len %lu)\n", err, package_size); goto out; } - IWL_DEBUG_FW(trans, "Read PNVM fro UEFI with size %zd\n", package_size); + IWL_DEBUG_FW(trans, "Read PNVM fro UEFI with size %lu\n", package_size); *data = kmemdup(package->data, *len, GFP_KERNEL); if (!*data)
An unsigned long variable should rely on '%lu' format strings, not '%zd' Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- warnings found with v5.12-rc1 and next-20210301 drivers/net/wireless/intel/iwlwifi/fw/pnvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)