| Message ID | 1614045328-87234-1-git-send-email-joseph.qi@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/bfq: update comments and default value in docs for fifo_expire | expand |
> Il giorno 23 feb 2021, alle ore 02:55, Joseph Qi <joseph.qi@linux.alibaba.com> ha scritto: > > Correct the comments since bfq_fifo_expire[0] is for async request, > while bfq_fifo_expire[1] is for sync request. > Also update docs, according the source code, the default > fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. > Thank you! Acked-by: Paolo Valente <paolo.valente@linaro.org> > Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > Documentation/block/bfq-iosched.rst | 4 ++-- > block/bfq-iosched.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst > index 19d4d15..66c5a4e 100644 > --- a/Documentation/block/bfq-iosched.rst > +++ b/Documentation/block/bfq-iosched.rst > @@ -430,13 +430,13 @@ fifo_expire_async > ----------------- > > This parameter is used to set the timeout of asynchronous requests. Default > -value of this is 248ms. > +value of this is 250ms. > > fifo_expire_sync > ---------------- > > This parameter is used to set the timeout of synchronous requests. Default > -value of this is 124ms. In case to favor synchronous requests over asynchronous > +value of this is 125ms. In case to favor synchronous requests over asynchronous > one, this value should be decreased relative to fifo_expire_async. > > low_latency > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index b398dde..2baa10b 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -160,7 +160,7 @@ > BFQ_BFQQ_FNS(softrt_update); > #undef BFQ_BFQQ_FNS \ > > -/* Expiration time of sync (0) and async (1) requests, in ns. */ > +/* Expiration time of async (0) and sync (1) requests, in ns. */ > static const u64 bfq_fifo_expire[2] = { NSEC_PER_SEC / 4, NSEC_PER_SEC / 8 }; > > /* Maximum backwards seek (magic number lifted from CFQ), in KiB. */ > -- > 1.8.3.1 >
On 2/23/21 4:25 PM, Paolo Valente wrote: > > >> Il giorno 23 feb 2021, alle ore 02:55, Joseph Qi <joseph.qi@linux.alibaba.com> ha scritto: >> >> Correct the comments since bfq_fifo_expire[0] is for async request, >> while bfq_fifo_expire[1] is for sync request. >> Also update docs, according the source code, the default >> fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. >> > > Thank you! > > Acked-by: Paolo Valente <paolo.valente@linaro.org> > Jens, could you take this? Thanks, Joseph
On 2/22/21 6:55 PM, Joseph Qi wrote: > Correct the comments since bfq_fifo_expire[0] is for async request, > while bfq_fifo_expire[1] is for sync request. > Also update docs, according the source code, the default > fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. Applied, thanks.
diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst index 19d4d15..66c5a4e 100644 --- a/Documentation/block/bfq-iosched.rst +++ b/Documentation/block/bfq-iosched.rst @@ -430,13 +430,13 @@ fifo_expire_async ----------------- This parameter is used to set the timeout of asynchronous requests. Default -value of this is 248ms. +value of this is 250ms. fifo_expire_sync ---------------- This parameter is used to set the timeout of synchronous requests. Default -value of this is 124ms. In case to favor synchronous requests over asynchronous +value of this is 125ms. In case to favor synchronous requests over asynchronous one, this value should be decreased relative to fifo_expire_async. low_latency diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index b398dde..2baa10b 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -160,7 +160,7 @@ BFQ_BFQQ_FNS(softrt_update); #undef BFQ_BFQQ_FNS \ -/* Expiration time of sync (0) and async (1) requests, in ns. */ +/* Expiration time of async (0) and sync (1) requests, in ns. */ static const u64 bfq_fifo_expire[2] = { NSEC_PER_SEC / 4, NSEC_PER_SEC / 8 }; /* Maximum backwards seek (magic number lifted from CFQ), in KiB. */
Correct the comments since bfq_fifo_expire[0] is for async request, while bfq_fifo_expire[1] is for sync request. Also update docs, according the source code, the default fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com> --- Documentation/block/bfq-iosched.rst | 4 ++-- block/bfq-iosched.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)