[v4,0/3] Cleanup and fixups for vmemmap handling

Message

Oscar Salvador March 1, 2021, 8:32 a.m. UTC

Hi Andrew,

Now that 5.12-rc1 is out, and as discussed, here there is a new version on top
of it.
Please, consider picking up the series.

Thanks

Original cover letter:

----

Hi,

this series contains cleanups to remove dead code that handles
unaligned cases for 4K and 1GB pages (patch#1 and patch#2) when
removing the vemmmap range, and a fix (patch#3) to handle the case
when two vmemmap ranges intersect the same PMD.

More details can be found in the respective changelogs.

 v3 -> v4:
 - Rebase on top of 5.12-rc1 as Andrew suggested
 - Added last Reviewed-by for the last patch

 v2 -> v3:
 - Make sure we do not clear the PUD entry in case
   we are not removing the whole range.
 - Add Reviewed-by

 v1 -> v2:
 - Remove dead code in remove_pud_table as well
 - Addessed feedback by David
 - Place the vmemap functions that take care of unaligned PMDs
   within CONFIG_SPARSEMEM_VMEMMAP


Oscar Salvador (3):
  x86/vmemmap: Drop handling of 4K unaligned vmemmap range
  x86/vmemmap: Drop handling of 1GB vmemmap ranges
  x86/vmemmap: Handle unpopulated sub-pmd ranges

 arch/x86/mm/init_64.c | 189 +++++++++++++++++++++++++++++++-------------------
 1 file changed, 118 insertions(+), 71 deletions(-)

Comments

Andrew Morton March 3, 2021, 12:09 a.m. UTC | #1

On Mon,  1 Mar 2021 09:32:27 +0100 Oscar Salvador <[e-mail]> wrote:

> Hi Andrew,
> 
> Now that 5.12-rc1 is out, and as discussed, here there is a new version on top
> of it.
> Please, consider picking up the series.
>

I grabbed them, but...

> 
>  arch/x86/mm/init_64.c | 189 +++++++++++++++++++++++++++++++-------------------

Perhaps a better route would be via an x86 tree.

Borislav Petkov March 3, 2021, 6:38 p.m. UTC | #2

On Tue, Mar 02, 2021 at 04:09:35PM -0800, Andrew Morton wrote:
> >  arch/x86/mm/init_64.c | 189 +++++++++++++++++++++++++++++++-------------------
> 
> Perhaps a better route would be via an x86 tree.

I assumed you took mm stuff, even if arch-specific. I can still take
them through tip if you prefer...

Thx.

Andrew Morton March 3, 2021, 11:04 p.m. UTC | #3

On Wed, 3 Mar 2021 19:38:30 +0100 Borislav Petkov <[e-mail]> wrote:

> On Tue, Mar 02, 2021 at 04:09:35PM -0800, Andrew Morton wrote:
> > >  arch/x86/mm/init_64.c | 189 +++++++++++++++++++++++++++++++-------------------
> > 
> > Perhaps a better route would be via an x86 tree.
> 
> I assumed you took mm stuff, even if arch-specific. I can still take
> them through tip if you prefer...
> 

I don't mind.  Some review-and-acking would be nice?