ASoC: SOF: Intel: hda: enable async suspend

Commit Message

Ranjani Sridharan March 1, 2021, 5:01 p.m. UTC

The skylake driver disabled async suspend to prevent disabling
the DSP before the card was suspended during system suspend.
This code was carried over to the SOF driver. But, there is no
risk of the DSP getting disabled before the card is suspended
with the SOF driver. Therefore, it is safe to enable async suspend
and thereby optimize the system resume time.

Reviewed-by: Kai Vehmanen <[e-mail]>
Reviewed-by: Pierre-Louis Bossart <[e-mail]>
Signed-off-by: Ranjani Sridharan <[e-mail]>
---
 sound/soc/sof/intel/hda.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Brown March 4, 2021, 12:54 a.m. UTC | #1

On Mon, 1 Mar 2021 09:01:57 -0800, Ranjani Sridharan wrote:
> The skylake driver disabled async suspend to prevent disabling
> the DSP before the card was suspended during system suspend.
> This code was carried over to the SOF driver. But, there is no
> risk of the DSP getting disabled before the card is suspended
> with the SOF driver. Therefore, it is safe to enable async suspend
> and thereby optimize the system resume time.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: Intel: hda: enable async suspend
      commit: 75c64508dfa6679f2969e68313ee4f7fbdac865b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index 0dc3a8c0f5e3..25b799f0accc 100644
--- a/sound/soc/sof/intel/hda.c
+++ b/sound/soc/sof/intel/hda.c
@@ -614,8 +614,6 @@  static int hda_init_caps(struct snd_sof_dev *sdev)
 	u32 link_mask;
 	int ret = 0;
 
-	device_disable_async_suspend(bus->dev);
-
 	/* check if dsp is there */
 	if (bus->ppcap)
 		dev_dbg(sdev->dev, "PP capability, will probe DSP later.\n");