| Message ID | 20210303144631.3175331-14-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rid W=1 warnings in SCSI | expand |
On Wed, Mar 3, 2021 at 3:47 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for pm8001_ctl_sas_address_show(). Prototype was for pm8001_ctl_host_sas_address_show() instead > drivers/scsi/pm8001/pm8001_ctl.c:530: warning: expecting prototype for pm8001_ctl_aap_log_show(). Prototype was for pm8001_ctl_iop_log_show() instead > > Cc: Jack Wang <jinpu.wang@cloud.ionos.com> > Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com> Thanks > --- > drivers/scsi/pm8001/pm8001_ctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c > index 12035baf0997b..1921e69bc2328 100644 > --- a/drivers/scsi/pm8001/pm8001_ctl.c > +++ b/drivers/scsi/pm8001/pm8001_ctl.c > @@ -299,7 +299,7 @@ static DEVICE_ATTR(sas_spec_support, S_IRUGO, > pm8001_ctl_sas_spec_support_show, NULL); > > /** > - * pm8001_ctl_sas_address_show - sas address > + * pm8001_ctl_host_sas_address_show - sas address > * @cdev: pointer to embedded class device > * @attr: device attribute (unused) > * @buf: the buffer returned > @@ -518,7 +518,7 @@ static ssize_t event_log_size_show(struct device *cdev, > } > static DEVICE_ATTR_RO(event_log_size); > /** > - * pm8001_ctl_aap_log_show - IOP event log > + * pm8001_ctl_iop_log_show - IOP event log > * @cdev: pointer to embedded class device > * @attr: device attribute (unused) > * @buf: the buffer returned > -- > 2.27.0 >
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 12035baf0997b..1921e69bc2328 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -299,7 +299,7 @@ static DEVICE_ATTR(sas_spec_support, S_IRUGO, pm8001_ctl_sas_spec_support_show, NULL); /** - * pm8001_ctl_sas_address_show - sas address + * pm8001_ctl_host_sas_address_show - sas address * @cdev: pointer to embedded class device * @attr: device attribute (unused) * @buf: the buffer returned @@ -518,7 +518,7 @@ static ssize_t event_log_size_show(struct device *cdev, } static DEVICE_ATTR_RO(event_log_size); /** - * pm8001_ctl_aap_log_show - IOP event log + * pm8001_ctl_iop_log_show - IOP event log * @cdev: pointer to embedded class device * @attr: device attribute (unused) * @buf: the buffer returned
Fixes the following W=1 kernel build warning(s): drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for pm8001_ctl_sas_address_show(). Prototype was for pm8001_ctl_host_sas_address_show() instead drivers/scsi/pm8001/pm8001_ctl.c:530: warning: expecting prototype for pm8001_ctl_aap_log_show(). Prototype was for pm8001_ctl_iop_log_show() instead Cc: Jack Wang <jinpu.wang@cloud.ionos.com> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/scsi/pm8001/pm8001_ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)