| Message ID | 20210304131513.3052-1-dnlplm@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6c59cff38e66584ae3ac6c2f0cbd8d039c710ba7 |
| Headers | show |
| Series | [1/1] net: usb: qmi_wwan: allow qmimux add/del with master up | expand |
Daniele Palmas <dnlplm@gmail.com> writes: > There's no reason for preventing the creation and removal > of qmimux network interfaces when the underlying interface > is up. > > This makes qmi_wwan mux implementation more similar to the > rmnet one, simplifying userspace management of the same > logical interfaces. > > Fixes: c6adf77953bc ("net: usb: qmi_wwan: add qmap mux protocol support") > Reported-by: Aleksander Morgado <aleksander@aleksander.es> > Signed-off-by: Daniele Palmas <dnlplm@gmail.com> Acked-by: Bjørn Mork <bjorn@mork.no>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 4 Mar 2021 14:15:13 +0100 you wrote: > There's no reason for preventing the creation and removal > of qmimux network interfaces when the underlying interface > is up. > > This makes qmi_wwan mux implementation more similar to the > rmnet one, simplifying userspace management of the same > logical interfaces. > > [...] Here is the summary with links: - [1/1] net: usb: qmi_wwan: allow qmimux add/del with master up https://git.kernel.org/netdev/net/c/6c59cff38e66 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 17a050521b86..6700f1970b24 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -429,13 +429,6 @@ static ssize_t add_mux_store(struct device *d, struct device_attribute *attr, c goto err; } - /* we don't want to modify a running netdev */ - if (netif_running(dev->net)) { - netdev_err(dev->net, "Cannot change a running device\n"); - ret = -EBUSY; - goto err; - } - ret = qmimux_register_device(dev->net, mux_id); if (!ret) { info->flags |= QMI_WWAN_FLAG_MUX; @@ -465,13 +458,6 @@ static ssize_t del_mux_store(struct device *d, struct device_attribute *attr, c if (!rtnl_trylock()) return restart_syscall(); - /* we don't want to modify a running netdev */ - if (netif_running(dev->net)) { - netdev_err(dev->net, "Cannot change a running device\n"); - ret = -EBUSY; - goto err; - } - del_dev = qmimux_find_dev(dev, mux_id); if (!del_dev) { netdev_err(dev->net, "mux_id not present\n");
There's no reason for preventing the creation and removal of qmimux network interfaces when the underlying interface is up. This makes qmi_wwan mux implementation more similar to the rmnet one, simplifying userspace management of the same logical interfaces. Fixes: c6adf77953bc ("net: usb: qmi_wwan: add qmap mux protocol support") Reported-by: Aleksander Morgado <aleksander@aleksander.es> Signed-off-by: Daniele Palmas <dnlplm@gmail.com> --- drivers/net/usb/qmi_wwan.c | 14 -------------- 1 file changed, 14 deletions(-)