diff mbox series

[v2,1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller

Message ID 20210224075640.20465-2-noltari@gmail.com (mailing list archive)
State Not Applicable
Headers show
Series [v2,1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller | expand

Commit Message

Álvaro Fernández Rojas Feb. 24, 2021, 7:56 a.m. UTC 
Document the binding for the BCM6345 external interrupt controller.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 v3: pass dt_binding_check.
 v2: fix title typo.

 .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml

Comments

Rob Herring (Arm) March 6, 2021, 8:14 p.m. UTC | #1 
On Wed, Feb 24, 2021 at 08:56:39AM +0100, Álvaro Fernández Rojas wrote:
> Document the binding for the BCM6345 external interrupt controller.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  v3: pass dt_binding_check.
>  v2: fix title typo.
> 
>  .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> new file mode 100644
> index 000000000000..a691510e78b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM6345 external interrupt controller
> +
> +maintainers:
> +  - Álvaro Fernández Rojas <noltari@gmail.com>
> +  - Jonas Gorski <jonas.gorski@gmail.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm6318-ext-intc
> +      - brcm,bcm6345-ext-intc
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 0
> +
> +  interrupt-controller: true
> +
> +  interrupts:
> +    description: Specifies the interrupt line(s) in the interrupt-parent
> +      controller node. Valid values depend on the type of parent interrupt
> +      controller.
> +    maxItems: 4
> +
> +  brcm,field-width:
> +    description: Interrupt controller field width (the default is 4).

default: 4

> +    maxItems: 1

All uint32's are 1 item.

What's the set or range of values?

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> +  - "#address-cells"
> +  - compatible
> +  - reg
> +  - "#interrupt-cells"
> +  - interrupt-controller
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller@10000018 {
> +      #address-cells = <0>;
> +      compatible = "brcm,bcm6345-ext-intc";
> +      reg = <0x10000018 0x4>;
> +
> +      interrupt-parent = <&periph_intc>;
> +      #interrupt-cells = <2>;
> +
> +      interrupt-controller;
> +      interrupts = <24>, <25>, <26>, <27>;
> +    };
> +
> +  - |
> +    interrupt-controller@fffe0014 {
> +      #address-cells = <0>;
> +      compatible = "brcm,bcm6345-ext-intc";
> +      reg = <0xfffe0014 0x4>;
> +
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +
> +      interrupt-parent = <&cpu_intc>;
> +      interrupts = <3>, <4>, <5>, <6>;
> +
> +      brcm,field-width = <5>;
> +    };
> -- 
> 2.20.1
>
Álvaro Fernández Rojas March 7, 2021, 10:12 a.m. UTC | #2 
Hi Rob,

El 06/03/2021 a las 21:14, Rob Herring escribió:
> On Wed, Feb 24, 2021 at 08:56:39AM +0100, Álvaro Fernández Rojas wrote:
>> Document the binding for the BCM6345 external interrupt controller.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   v3: pass dt_binding_check.
>>   v2: fix title typo.
>>
>>   .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
>>   1 file changed, 78 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
>> new file mode 100644
>> index 000000000000..a691510e78b7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
>> @@ -0,0 +1,78 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Broadcom BCM6345 external interrupt controller
>> +
>> +maintainers:
>> +  - Álvaro Fernández Rojas <noltari@gmail.com>
>> +  - Jonas Gorski <jonas.gorski@gmail.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - brcm,bcm6318-ext-intc
>> +      - brcm,bcm6345-ext-intc
>> +
>> +  "#interrupt-cells":
>> +    const: 2
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  "#address-cells":
>> +    const: 0
>> +
>> +  interrupt-controller: true
>> +
>> +  interrupts:
>> +    description: Specifies the interrupt line(s) in the interrupt-parent
>> +      controller node. Valid values depend on the type of parent interrupt
>> +      controller.
>> +    maxItems: 4
>> +
>> +  brcm,field-width:
>> +    description: Interrupt controller field width (the default is 4).
> 
> default: 4
> 
>> +    maxItems: 1
> 
> All uint32's are 1 item.

Ok, so I should remove this :)

> 
> What's the set or range of values?

Only BCM6348 needs to set this value to 5, other BCM63xx use the default 
value of 4 (BCM3368, BCM6318, BCM6328, BCM6338, BCM6345, BCM6358, 
BCM6362, BCM6368, BCM63268).

> 
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> +required:
>> +  - "#address-cells"
>> +  - compatible
>> +  - reg
>> +  - "#interrupt-cells"
>> +  - interrupt-controller
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    interrupt-controller@10000018 {
>> +      #address-cells = <0>;
>> +      compatible = "brcm,bcm6345-ext-intc";
>> +      reg = <0x10000018 0x4>;
>> +
>> +      interrupt-parent = <&periph_intc>;
>> +      #interrupt-cells = <2>;
>> +
>> +      interrupt-controller;
>> +      interrupts = <24>, <25>, <26>, <27>;
>> +    };
>> +
>> +  - |
>> +    interrupt-controller@fffe0014 {
>> +      #address-cells = <0>;
>> +      compatible = "brcm,bcm6345-ext-intc";
>> +      reg = <0xfffe0014 0x4>;
>> +
>> +      interrupt-controller;
>> +      #interrupt-cells = <2>;
>> +
>> +      interrupt-parent = <&cpu_intc>;
>> +      interrupts = <3>, <4>, <5>, <6>;
>> +
>> +      brcm,field-width = <5>;
>> +    };
>> -- 
>> 2.20.1
>>

Best regards,
Álvaro.
Rob Herring (Arm) March 10, 2021, 5:21 p.m. UTC | #3 
On Sun, Mar 7, 2021 at 3:12 AM Álvaro Fernández Rojas <noltari@gmail.com> wrote:
>
> Hi Rob,
>
> El 06/03/2021 a las 21:14, Rob Herring escribió:
> > On Wed, Feb 24, 2021 at 08:56:39AM +0100, Álvaro Fernández Rojas wrote:
> >> Document the binding for the BCM6345 external interrupt controller.
> >>
> >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> >> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >>   v3: pass dt_binding_check.
> >>   v2: fix title typo.
> >>
> >>   .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
> >>   1 file changed, 78 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >> new file mode 100644
> >> index 000000000000..a691510e78b7
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> >> @@ -0,0 +1,78 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Broadcom BCM6345 external interrupt controller
> >> +
> >> +maintainers:
> >> +  - Álvaro Fernández Rojas <noltari@gmail.com>
> >> +  - Jonas Gorski <jonas.gorski@gmail.com>
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - brcm,bcm6318-ext-intc
> >> +      - brcm,bcm6345-ext-intc
> >> +
> >> +  "#interrupt-cells":
> >> +    const: 2
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  "#address-cells":
> >> +    const: 0
> >> +
> >> +  interrupt-controller: true
> >> +
> >> +  interrupts:
> >> +    description: Specifies the interrupt line(s) in the interrupt-parent
> >> +      controller node. Valid values depend on the type of parent interrupt
> >> +      controller.
> >> +    maxItems: 4
> >> +
> >> +  brcm,field-width:
> >> +    description: Interrupt controller field width (the default is 4).
> >
> > default: 4
> >
> >> +    maxItems: 1
> >
> > All uint32's are 1 item.
>
> Ok, so I should remove this :)
>
> >
> > What's the set or range of values?
>
> Only BCM6348 needs to set this value to 5, other BCM63xx use the default
> value of 4 (BCM3368, BCM6318, BCM6328, BCM6338, BCM6345, BCM6358,
> BCM6362, BCM6368, BCM63268).

So:

enum: [ 4, 5 ]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
new file mode 100644
index 000000000000..a691510e78b7
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
@@ -0,0 +1,78 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM6345 external interrupt controller
+
+maintainers:
+  - Álvaro Fernández Rojas <noltari@gmail.com>
+  - Jonas Gorski <jonas.gorski@gmail.com>
+
+properties:
+  compatible:
+    enum:
+      - brcm,bcm6318-ext-intc
+      - brcm,bcm6345-ext-intc
+
+  "#interrupt-cells":
+    const: 2
+
+  reg:
+    maxItems: 1
+
+  "#address-cells":
+    const: 0
+
+  interrupt-controller: true
+
+  interrupts:
+    description: Specifies the interrupt line(s) in the interrupt-parent
+      controller node. Valid values depend on the type of parent interrupt
+      controller.
+    maxItems: 4
+
+  brcm,field-width:
+    description: Interrupt controller field width (the default is 4).
+    maxItems: 1
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - "#address-cells"
+  - compatible
+  - reg
+  - "#interrupt-cells"
+  - interrupt-controller
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@10000018 {
+      #address-cells = <0>;
+      compatible = "brcm,bcm6345-ext-intc";
+      reg = <0x10000018 0x4>;
+
+      interrupt-parent = <&periph_intc>;
+      #interrupt-cells = <2>;
+
+      interrupt-controller;
+      interrupts = <24>, <25>, <26>, <27>;
+    };
+
+  - |
+    interrupt-controller@fffe0014 {
+      #address-cells = <0>;
+      compatible = "brcm,bcm6345-ext-intc";
+      reg = <0xfffe0014 0x4>;
+
+      interrupt-controller;
+      #interrupt-cells = <2>;
+
+      interrupt-parent = <&cpu_intc>;
+      interrupts = <3>, <4>, <5>, <6>;
+
+      brcm,field-width = <5>;
+    };