| Message ID | 20210308150050.19902-1-pc@cjr.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] cifs: print MIDs in decimal notation | expand |
Paulo Alcantara <pc@cjr.nz> writes: > The MIDs are mostly printed as decimal, so let's make it consistent. Reviewed-by: Aurelien Aptel <aaptel@suse.com>
reviewed-by me On Tue, Mar 9, 2021 at 1:02 AM Paulo Alcantara <pc@cjr.nz> wrote: > > The MIDs are mostly printed as decimal, so let's make it consistent. > > Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz> > --- > fs/cifs/cifs_debug.c | 2 +- > fs/cifs/connect.c | 4 ++-- > fs/cifs/smb2misc.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c > index 3aedc484e440..88a7958170ee 100644 > --- a/fs/cifs/cifs_debug.c > +++ b/fs/cifs/cifs_debug.c > @@ -207,7 +207,7 @@ static int cifs_debug_files_proc_show(struct seq_file *m, void *v) > from_kuid(&init_user_ns, cfile->uid), > cfile->dentry); > #ifdef CONFIG_CIFS_DEBUG2 > - seq_printf(m, " 0x%llx\n", cfile->fid.mid); > + seq_printf(m, " %llu\n", cfile->fid.mid); > #else > seq_printf(m, "\n"); > #endif /* CIFS_DEBUG2 */ > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 68642e3d4270..eec8a2052da2 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -741,7 +741,7 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server) > spin_lock(&GlobalMid_Lock); > list_for_each_safe(tmp, tmp2, &server->pending_mid_q) { > mid_entry = list_entry(tmp, struct mid_q_entry, qhead); > - cifs_dbg(FYI, "Clearing mid 0x%llx\n", mid_entry->mid); > + cifs_dbg(FYI, "Clearing mid %llu\n", mid_entry->mid); > kref_get(&mid_entry->refcount); > mid_entry->mid_state = MID_SHUTDOWN; > list_move(&mid_entry->qhead, &dispose_list); > @@ -752,7 +752,7 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server) > /* now walk dispose list and issue callbacks */ > list_for_each_safe(tmp, tmp2, &dispose_list) { > mid_entry = list_entry(tmp, struct mid_q_entry, qhead); > - cifs_dbg(FYI, "Callback mid 0x%llx\n", mid_entry->mid); > + cifs_dbg(FYI, "Callback mid %llu\n", mid_entry->mid); > list_del_init(&mid_entry->qhead); > mid_entry->callback(mid_entry); > cifs_mid_q_entry_release(mid_entry); > diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c > index 3ea3bda64083..0a55a77d94de 100644 > --- a/fs/cifs/smb2misc.c > +++ b/fs/cifs/smb2misc.c > @@ -767,7 +767,7 @@ smb2_cancelled_close_fid(struct work_struct *work) > int rc; > > if (cancelled->mid) > - cifs_tcon_dbg(VFS, "Close unmatched open for MID:%llx\n", > + cifs_tcon_dbg(VFS, "Close unmatched open for MID:%llu\n", > cancelled->mid); > else > cifs_tcon_dbg(VFS, "Close interrupted close\n"); > -- > 2.30.1 >
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 3aedc484e440..88a7958170ee 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c @@ -207,7 +207,7 @@ static int cifs_debug_files_proc_show(struct seq_file *m, void *v) from_kuid(&init_user_ns, cfile->uid), cfile->dentry); #ifdef CONFIG_CIFS_DEBUG2 - seq_printf(m, " 0x%llx\n", cfile->fid.mid); + seq_printf(m, " %llu\n", cfile->fid.mid); #else seq_printf(m, "\n"); #endif /* CIFS_DEBUG2 */ diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 68642e3d4270..eec8a2052da2 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -741,7 +741,7 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server) spin_lock(&GlobalMid_Lock); list_for_each_safe(tmp, tmp2, &server->pending_mid_q) { mid_entry = list_entry(tmp, struct mid_q_entry, qhead); - cifs_dbg(FYI, "Clearing mid 0x%llx\n", mid_entry->mid); + cifs_dbg(FYI, "Clearing mid %llu\n", mid_entry->mid); kref_get(&mid_entry->refcount); mid_entry->mid_state = MID_SHUTDOWN; list_move(&mid_entry->qhead, &dispose_list); @@ -752,7 +752,7 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server) /* now walk dispose list and issue callbacks */ list_for_each_safe(tmp, tmp2, &dispose_list) { mid_entry = list_entry(tmp, struct mid_q_entry, qhead); - cifs_dbg(FYI, "Callback mid 0x%llx\n", mid_entry->mid); + cifs_dbg(FYI, "Callback mid %llu\n", mid_entry->mid); list_del_init(&mid_entry->qhead); mid_entry->callback(mid_entry); cifs_mid_q_entry_release(mid_entry); diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 3ea3bda64083..0a55a77d94de 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs/smb2misc.c @@ -767,7 +767,7 @@ smb2_cancelled_close_fid(struct work_struct *work) int rc; if (cancelled->mid) - cifs_tcon_dbg(VFS, "Close unmatched open for MID:%llx\n", + cifs_tcon_dbg(VFS, "Close unmatched open for MID:%llu\n", cancelled->mid); else cifs_tcon_dbg(VFS, "Close interrupted close\n");
The MIDs are mostly printed as decimal, so let's make it consistent. Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz> --- fs/cifs/cifs_debug.c | 2 +- fs/cifs/connect.c | 4 ++-- fs/cifs/smb2misc.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)