| Message ID | 20210309102157.365356-4-david.edmondson@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coroutine rwlock downgrade fix, minor VDI changes | expand |
On 09/03/21 11:21, David Edmondson wrote: > When taking the slow path for mutex acquisition, set the coroutine > value in the CoWaitRecord in push_waiter(), rather than both there and > in the caller. > > Signed-off-by: David Edmondson <david.edmondson@oracle.com> > --- > util/qemu-coroutine-lock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c > index 5816bf8900..eb73cf11dc 100644 > --- a/util/qemu-coroutine-lock.c > +++ b/util/qemu-coroutine-lock.c > @@ -204,7 +204,6 @@ static void coroutine_fn qemu_co_mutex_lock_slowpath(AioContext *ctx, > unsigned old_handoff; > > trace_qemu_co_mutex_lock_entry(mutex, self); > - w.co = self; > push_waiter(mutex, &w); > > /* This is the "Responsibility Hand-Off" protocol; a lock() picks from > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On 3/9/21 11:21 AM, David Edmondson wrote: > When taking the slow path for mutex acquisition, set the coroutine > value in the CoWaitRecord in push_waiter(), rather than both there and > in the caller. > > Signed-off-by: David Edmondson <david.edmondson@oracle.com> > --- > util/qemu-coroutine-lock.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c index 5816bf8900..eb73cf11dc 100644 --- a/util/qemu-coroutine-lock.c +++ b/util/qemu-coroutine-lock.c @@ -204,7 +204,6 @@ static void coroutine_fn qemu_co_mutex_lock_slowpath(AioContext *ctx, unsigned old_handoff; trace_qemu_co_mutex_lock_entry(mutex, self); - w.co = self; push_waiter(mutex, &w); /* This is the "Responsibility Hand-Off" protocol; a lock() picks from
When taking the slow path for mutex acquisition, set the coroutine value in the CoWaitRecord in push_waiter(), rather than both there and in the caller. Signed-off-by: David Edmondson <david.edmondson@oracle.com> --- util/qemu-coroutine-lock.c | 1 - 1 file changed, 1 deletion(-)