| Message ID | 20210309103528.3538910-1-kuldeep.singh@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Mark Brown |
| Headers | show |
| Series | dt-bindings: spi: Convert NXP flexspi to json schema | expand |
+ Mark (Forgot to add him previously) > -----Original Message----- > From: Kuldeep Singh <kuldeep.singh@nxp.com> > Sent: Tuesday, March 9, 2021 4:05 PM > To: Rob Herring <robh+dt@kernel.org>; linux-spi@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Ashish Kumar <ashish.kumar@nxp.com>; Kuldeep Singh > <kuldeep.singh@nxp.com> > Subject: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema > > Convert the NXP FlexSPI binding to DT schema format using json-schema. > > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> > Hi Rob and Mark, I was not sure with which tree this patch will go through. Currently, I have rebased this on top of tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, branch: for-next) Regards Kuldeep
On Tue, Mar 09, 2021 at 11:41:50AM +0000, Kuldeep Singh wrote: > + Mark (Forgot to add him previously) ... > I was not sure with which tree this patch will go through. > Currently, I have rebased this on top of tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, branch: for-next) Binding patches generally go through the subsystem tree so please send the patch to me.
Hi Mark, > -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Tuesday, March 9, 2021 6:06 PM > To: Kuldeep Singh <kuldeep.singh@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org>; linux-spi@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ashish Kumar > <ashish.kumar@nxp.com> > Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema > > On Tue, Mar 09, 2021 at 11:41:50AM +0000, Kuldeep Singh wrote: > > + Mark (Forgot to add him previously) > > ... > > > I was not sure with which tree this patch will go through. > > Currently, I have rebased this on top of > > tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, > > branch: for-next) > > Binding patches generally go through the subsystem tree so please send the patch > to me. Thanks for letting me know. I have developed the patch on top of your tree and also sent to spi-devel mailing list. Please see [1] for more details. Kindly let me know if I need to resubmit the patch. Regards Kuldeep [1] https://patchwork.kernel.org/project/spi-devel-general/patch/20210309103528.3538910-1-kuldeep.singh@nxp.com/
On Tue, Mar 09, 2021 at 05:30:00PM +0000, Kuldeep Singh wrote: > > Binding patches generally go through the subsystem tree so please send the patch > > to me. > Thanks for letting me know. > I have developed the patch on top of your tree and also sent to spi-devel mailing list. > Please see [1] for more details. Kindly let me know if I need to resubmit the patch. Like I said in the mail you're replying to please send me a copy of the patch.
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Tuesday, March 9, 2021 11:02 PM > To: Kuldeep Singh <kuldeep.singh@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org>; linux-spi@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ashish Kumar > <ashish.kumar@nxp.com> > Subject: Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema > > On Tue, Mar 09, 2021 at 05:30:00PM +0000, Kuldeep Singh wrote: > > > > Binding patches generally go through the subsystem tree so please > > > send the patch to me. > > > Thanks for letting me know. > > I have developed the patch on top of your tree and also sent to spi-devel > mailing list. > > Please see [1] for more details. Kindly let me know if I need to resubmit the > patch. > > Like I said in the mail you're replying to please send me a copy of the patch. I hope this will suffice. Please let me know in case of any other requirement. Regards Kuldeep [1] Convert the NXP FlexSPI binding to DT schema format using json-schema. Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> --- .../bindings/spi/nxp,spi-nxp-fspi.yaml | 85 +++++++++++++++++++ .../devicetree/bindings/spi/spi-nxp-fspi.txt | 43 ---------- MAINTAINERS | 2 +- 3 files changed, 86 insertions(+), 44 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt diff --git a/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml new file mode 100644 index 000000000000..e3f2c5aae847 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml @@ -0,0 +1,85 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/nxp,spi-nxp-fspi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Flex Serial Peripheral Interface (FSPI) + +maintainers: + - Ashish Kumar <ashish.kumar@nxp.com> + +allOf: + - $ref: "spi-controller.yaml#" + +properties: + compatible: + enum: + - nxp,lx2160a-fspi + - nxp,imx8qxp-fspi + - nxp,imx8mm-fspi + - nxp,imx8dxl-fspi + + reg: + items: + - description: registers + - description: memory mapping + + reg-names: + items: + - const: fspi_base + - const: fspi_mmap + + interrupts: + maxItems: 1 + + clocks: + items: + - description: SoC SPI fspi_en clock + - description: SoC SPI fspi clock + + clock-names: + items: + - const: fspi_en + - const: fspi + +required: + - compatible + - reg + - reg-names + - interrupts + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/fsl,qoriq-clockgen.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + spi@20c0000 { + compatible = "nxp,lx2160a-fspi"; + reg = <0x0 0x20c0000 0x0 0x100000>, + <0x0 0x20000000 0x0 0x10000000>; + reg-names = "fspi_base", "fspi_mmap"; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>, + <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>; + clock-names = "fspi_en", "fspi"; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + spi-max-frequency = <50000000>; + reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <8>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt deleted file mode 100644 index df178d1b62e6..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt +++ /dev/null @@ -1,43 +0,0 @@ -* NXP Flex Serial Peripheral Interface (FSPI) - -Required properties: - - compatible : Should be "nxp,lx2160a-fspi" - "nxp,imx8qxp-fspi" - "nxp,imx8mm-fspi" - "nxp,imx8dxl-fspi" - - - reg : First contains the register location and length, - Second contains the memory mapping address and length - - reg-names : Should contain the resource reg names: - - fspi_base: configuration register address space - - fspi_mmap: memory mapped address space - - interrupts : Should contain the interrupt for the device - -Required SPI slave node properties: - - reg : There are two buses (A and B) with two chip selects each. - This encodes to which bus and CS the flash is connected: - - <0>: Bus A, CS 0 - - <1>: Bus A, CS 1 - - <2>: Bus B, CS 0 - - <3>: Bus B, CS 1 - -Example showing the usage of two SPI NOR slave devices on bus A: - -fspi0: spi@20c0000 { - compatible = "nxp,lx2160a-fspi"; - reg = <0x0 0x20c0000 0x0 0x10000>, <0x0 0x20000000 0x0 0x10000000>; - reg-names = "fspi_base", "fspi_mmap"; - interrupts = <0 25 0x4>; /* Level high type */ - clocks = <&clockgen 4 3>, <&clockgen 4 3>; - clock-names = "fspi_en", "fspi"; - - mt35xu512aba0: flash@0 { - reg = <0>; - .... - }; - - mt35xu512aba1: flash@1 { - reg = <1>; - .... - }; -}; diff --git a/MAINTAINERS b/MAINTAINERS index d92f85ca831d..8729f7b50945 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12832,7 +12832,7 @@ M: Ashish Kumar <ashish.kumar@nxp.com> R: Yogesh Gaur <yogeshgaur.83@gmail.com> L: linux-spi@vger.kernel.org S: Maintained -F: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt +F: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml F: drivers/spi/spi-nxp-fspi.c NXP FXAS21002C DRIVER -- 2.25.1
On Wed, Mar 10, 2021 at 10:24:21AM +0000, Kuldeep Singh wrote: > > Like I said in the mail you're replying to please send me a copy of the patch. > I hope this will suffice. Please let me know in case of any other requirement. Please submit the patch following the process documented in submitting-patches.rst.
diff --git a/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml new file mode 100644 index 000000000000..e3f2c5aae847 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml @@ -0,0 +1,85 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/nxp,spi-nxp-fspi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Flex Serial Peripheral Interface (FSPI) + +maintainers: + - Ashish Kumar <ashish.kumar@nxp.com> + +allOf: + - $ref: "spi-controller.yaml#" + +properties: + compatible: + enum: + - nxp,lx2160a-fspi + - nxp,imx8qxp-fspi + - nxp,imx8mm-fspi + - nxp,imx8dxl-fspi + + reg: + items: + - description: registers + - description: memory mapping + + reg-names: + items: + - const: fspi_base + - const: fspi_mmap + + interrupts: + maxItems: 1 + + clocks: + items: + - description: SoC SPI fspi_en clock + - description: SoC SPI fspi clock + + clock-names: + items: + - const: fspi_en + - const: fspi + +required: + - compatible + - reg + - reg-names + - interrupts + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/fsl,qoriq-clockgen.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + spi@20c0000 { + compatible = "nxp,lx2160a-fspi"; + reg = <0x0 0x20c0000 0x0 0x100000>, + <0x0 0x20000000 0x0 0x10000000>; + reg-names = "fspi_base", "fspi_mmap"; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>, + <&clockgen QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>; + clock-names = "fspi_en", "fspi"; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + spi-max-frequency = <50000000>; + reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <8>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt deleted file mode 100644 index df178d1b62e6..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt +++ /dev/null @@ -1,43 +0,0 @@ -* NXP Flex Serial Peripheral Interface (FSPI) - -Required properties: - - compatible : Should be "nxp,lx2160a-fspi" - "nxp,imx8qxp-fspi" - "nxp,imx8mm-fspi" - "nxp,imx8dxl-fspi" - - - reg : First contains the register location and length, - Second contains the memory mapping address and length - - reg-names : Should contain the resource reg names: - - fspi_base: configuration register address space - - fspi_mmap: memory mapped address space - - interrupts : Should contain the interrupt for the device - -Required SPI slave node properties: - - reg : There are two buses (A and B) with two chip selects each. - This encodes to which bus and CS the flash is connected: - - <0>: Bus A, CS 0 - - <1>: Bus A, CS 1 - - <2>: Bus B, CS 0 - - <3>: Bus B, CS 1 - -Example showing the usage of two SPI NOR slave devices on bus A: - -fspi0: spi@20c0000 { - compatible = "nxp,lx2160a-fspi"; - reg = <0x0 0x20c0000 0x0 0x10000>, <0x0 0x20000000 0x0 0x10000000>; - reg-names = "fspi_base", "fspi_mmap"; - interrupts = <0 25 0x4>; /* Level high type */ - clocks = <&clockgen 4 3>, <&clockgen 4 3>; - clock-names = "fspi_en", "fspi"; - - mt35xu512aba0: flash@0 { - reg = <0>; - .... - }; - - mt35xu512aba1: flash@1 { - reg = <1>; - .... - }; -}; diff --git a/MAINTAINERS b/MAINTAINERS index d92f85ca831d..8729f7b50945 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12832,7 +12832,7 @@ M: Ashish Kumar <ashish.kumar@nxp.com> R: Yogesh Gaur <yogeshgaur.83@gmail.com> L: linux-spi@vger.kernel.org S: Maintained -F: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt +F: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml F: drivers/spi/spi-nxp-fspi.c NXP FXAS21002C DRIVER
Convert the NXP FlexSPI binding to DT schema format using json-schema. Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> --- .../bindings/spi/nxp,spi-nxp-fspi.yaml | 85 +++++++++++++++++++ .../devicetree/bindings/spi/spi-nxp-fspi.txt | 43 ---------- MAINTAINERS | 2 +- 3 files changed, 86 insertions(+), 44 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt