diff mbox series

[v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC

Message ID 20210308174824.278372-1-krzysztof.kozlowski@canonical.com (mailing list archive)
State Queued, archived
Headers show
Series [v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC | expand

Commit Message

Krzysztof Kozlowski March 8, 2021, 5:48 p.m. UTC 
From: Krzysztof Kozlowski <krzk@kernel.org>

Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
and Keem Bay SoC.  This allows compile coverage when building default
config.

For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Hi Arnd,

You asked me to check if all drivers are enabled for these platforms.
In general the answer is yes. In particular:
1. Keem Bay is does not have much in upstream, but everything described
   in DTS is there,
2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
   supported.

Changes since v1:
1. Enable also SPI_DW_MMIO
---
 arch/arm64/configs/defconfig | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Dinh Nguyen March 8, 2021, 7:07 p.m. UTC | #1 
Hi Krzysztof,

On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
> and Keem Bay SoC.  This allows compile coverage when building default
> config.
> 
> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Hi Arnd,
> 
> You asked me to check if all drivers are enabled for these platforms.
> In general the answer is yes. In particular:
> 1. Keem Bay is does not have much in upstream, but everything described
>     in DTS is there,
> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
>     supported.
> 
> Changes since v1:
> 1. Enable also SPI_DW_MMIO
> ---
>   arch/arm64/configs/defconfig | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..9f9adcb8b0e9 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
>   CONFIG_PROFILING=y
>   CONFIG_ARCH_ACTIONS=y
>   CONFIG_ARCH_AGILEX=y
> +CONFIG_ARCH_N5X=y

I just submitted a patch for this as well. From the looks of the 
defconfig file, it looks like the platforms are in alphabetical order, 
but then I see that ARCH_SUNXI is not in it's correct spot if there is a 
rule for keeping things in alphabetical order.

I'll drop my patch.

Dinh

>   CONFIG_ARCH_SUNXI=y
>   CONFIG_ARCH_ALPINE=y
>   CONFIG_ARCH_BCM2835=y
> @@ -41,6 +42,7 @@ CONFIG_ARCH_K3=y
>   CONFIG_ARCH_LAYERSCAPE=y
>   CONFIG_ARCH_LG1K=y
>   CONFIG_ARCH_HISI=y
> +CONFIG_ARCH_KEEMBAY=y
>   CONFIG_ARCH_MEDIATEK=y
>   CONFIG_ARCH_MESON=y
>   CONFIG_ARCH_MVEBU=y
> @@ -465,6 +467,9 @@ CONFIG_SPI=y
>   CONFIG_SPI_ARMADA_3700=y
>   CONFIG_SPI_BCM2835=m
>   CONFIG_SPI_BCM2835AUX=m
> +CONFIG_SPI_DESIGNWARE=m
> +CONFIG_SPI_DW_DMA=y
> +CONFIG_SPI_DW_MMIO=m
>   CONFIG_SPI_FSL_LPSPI=y
>   CONFIG_SPI_FSL_QUADSPI=y
>   CONFIG_SPI_NXP_FLEXSPI=y
>
Krzysztof Kozlowski March 9, 2021, 9:29 a.m. UTC | #2 
On 08/03/2021 20:07, Dinh Nguyen wrote:
> Hi Krzysztof,
> 
> On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
>> and Keem Bay SoC.  This allows compile coverage when building default
>> config.
>>
>> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> ---
>>
>> Hi Arnd,
>>
>> You asked me to check if all drivers are enabled for these platforms.
>> In general the answer is yes. In particular:
>> 1. Keem Bay is does not have much in upstream, but everything described
>>     in DTS is there,
>> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
>>     supported.
>>
>> Changes since v1:
>> 1. Enable also SPI_DW_MMIO
>> ---
>>   arch/arm64/configs/defconfig | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index d612f633b771..9f9adcb8b0e9 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
>>   CONFIG_PROFILING=y
>>   CONFIG_ARCH_ACTIONS=y
>>   CONFIG_ARCH_AGILEX=y
>> +CONFIG_ARCH_N5X=y
> 
> I just submitted a patch for this as well. From the looks of the 
> defconfig file, it looks like the platforms are in alphabetical order, 
> but then I see that ARCH_SUNXI is not in it's correct spot if there is a 
> rule for keeping things in alphabetical order.
> 

The rule is that order comes from savedefconfig, not alphabetical. This
way you avoid reshuffling of symbols on any future savedefconfig.

Best regards,
Krzysztof
Dinh Nguyen March 9, 2021, 1:26 p.m. UTC | #3 
On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:
> On 08/03/2021 20:07, Dinh Nguyen wrote:
>> Hi Krzysztof,
>>
>> On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
>>> and Keem Bay SoC.  This allows compile coverage when building default
>>> config.
>>>
>>> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> ---
>>>
>>> Hi Arnd,
>>>
>>> You asked me to check if all drivers are enabled for these platforms.
>>> In general the answer is yes. In particular:
>>> 1. Keem Bay is does not have much in upstream, but everything described
>>>      in DTS is there,
>>> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
>>>      supported.
>>>
>>> Changes since v1:
>>> 1. Enable also SPI_DW_MMIO
>>> ---
>>>    arch/arm64/configs/defconfig | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index d612f633b771..9f9adcb8b0e9 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
>>>    CONFIG_PROFILING=y
>>>    CONFIG_ARCH_ACTIONS=y
>>>    CONFIG_ARCH_AGILEX=y
>>> +CONFIG_ARCH_N5X=y
>>
>> I just submitted a patch for this as well. From the looks of the
>> defconfig file, it looks like the platforms are in alphabetical order,
>> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
>> rule for keeping things in alphabetical order.
>>
> 
> The rule is that order comes from savedefconfig, not alphabetical. This
> way you avoid reshuffling of symbols on any future savedefconfig.
> 

Got it. But I've done savedefconfig in the past and Arnd adviced against 
that because what if multiple patches come in with savedefconfig, 
wouldn't that cause a messy merge?

Dinh
Arnd Bergmann March 9, 2021, 3:19 p.m. UTC | #4 
On Tue, Mar 9, 2021 at 2:26 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
> On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:
> > On 08/03/2021 20:07, Dinh Nguyen wrote:
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index d612f633b771..9f9adcb8b0e9 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
> >>>    CONFIG_PROFILING=y
> >>>    CONFIG_ARCH_ACTIONS=y
> >>>    CONFIG_ARCH_AGILEX=y
> >>> +CONFIG_ARCH_N5X=y
> >>
> >> I just submitted a patch for this as well. From the looks of the
> >> defconfig file, it looks like the platforms are in alphabetical order,
> >> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
> >> rule for keeping things in alphabetical order.
> >>
> >
> > The rule is that order comes from savedefconfig, not alphabetical. This
> > way you avoid reshuffling of symbols on any future savedefconfig.
> >
>
> Got it. But I've done savedefconfig in the past and Arnd adviced against
> that because what if multiple patches come in with savedefconfig,
> wouldn't that cause a messy merge?

To clarify: you should not send the result of 'make savedefconfig'
if it changes the contents of the file in another way, but Krzysztof's
recommendation of adding new lines where savedefconfig would
put them is best.

        Arnd
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..9f9adcb8b0e9 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -29,6 +29,7 @@  CONFIG_KALLSYMS_ALL=y
 CONFIG_PROFILING=y
 CONFIG_ARCH_ACTIONS=y
 CONFIG_ARCH_AGILEX=y
+CONFIG_ARCH_N5X=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_ARCH_ALPINE=y
 CONFIG_ARCH_BCM2835=y
@@ -41,6 +42,7 @@  CONFIG_ARCH_K3=y
 CONFIG_ARCH_LAYERSCAPE=y
 CONFIG_ARCH_LG1K=y
 CONFIG_ARCH_HISI=y
+CONFIG_ARCH_KEEMBAY=y
 CONFIG_ARCH_MEDIATEK=y
 CONFIG_ARCH_MESON=y
 CONFIG_ARCH_MVEBU=y
@@ -465,6 +467,9 @@  CONFIG_SPI=y
 CONFIG_SPI_ARMADA_3700=y
 CONFIG_SPI_BCM2835=m
 CONFIG_SPI_BCM2835AUX=m
+CONFIG_SPI_DESIGNWARE=m
+CONFIG_SPI_DW_DMA=y
+CONFIG_SPI_DW_MMIO=m
 CONFIG_SPI_FSL_LPSPI=y
 CONFIG_SPI_FSL_QUADSPI=y
 CONFIG_SPI_NXP_FLEXSPI=y