| Message ID | 1615294733-22761-6-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | PM / devfreq: a few small fixes and improvements | expand |
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > Use the more accurate returned new_freq as resume_freq. > It's the same as how devfreq->previous_freq was updated. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 6e80bf70e7b3..ce569bd9adfa 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > devfreq->previous_freq = new_freq; > > if (devfreq->suspend_freq) > - devfreq->resume_freq = cur_freq; > + devfreq->resume_freq = new_freq; > > return err; > } > This patch fixes the previous patch[1]. So that you need to add 'Fixes' tag as following: Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a devfreq device") commit 83f8ca45afbf041e312909f442128b99657d90b7 Refs: v4.20-rc6-2-g83f8ca45afbf Author: Lukasz Luba <lukasz.luba@arm.com> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 Commit: MyungJoo Ham <myungjoo.ham@samsung.com> CommitDate: Tue Dec 11 11:09:47 2018 +0900 PM / devfreq: add support for suspend/resume of a devfreq device
On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: > > On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > > Use the more accurate returned new_freq as resume_freq. > > It's the same as how devfreq->previous_freq was updated. > > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/devfreq/devfreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > > index 6e80bf70e7b3..ce569bd9adfa 100644 > > --- a/drivers/devfreq/devfreq.c > > +++ b/drivers/devfreq/devfreq.c > > @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > > devfreq->previous_freq = new_freq; > > > > if (devfreq->suspend_freq) > > - devfreq->resume_freq = cur_freq; > > + devfreq->resume_freq = new_freq; > > > > return err; > > } > > > > This patch fixes the previous patch[1]. So that you need to > add 'Fixes' tag as following: > > Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a > devfreq device") > Will add Fixes tag in next version. > commit 83f8ca45afbf041e312909f442128b99657d90b7 > Refs: v4.20-rc6-2-g83f8ca45afbf > Author: Lukasz Luba <lukasz.luba@arm.com> > AuthorDate: Wed Dec 5 12:05:53 2018 +0100 > Commit: MyungJoo Ham <myungjoo.ham@samsung.com> > CommitDate: Tue Dec 11 11:09:47 2018 +0900 > > PM / devfreq: add support for suspend/resume of a devfreq device > > > -- > Best Regards, > Samsung Electronics > Chanwoo Choi
On Wed, Mar 10, 2021 at 10:50 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > On 3/10/21 11:43 AM, Dong Aisheng wrote: > > On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: > >> > >> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > >>> Use the more accurate returned new_freq as resume_freq. > >>> It's the same as how devfreq->previous_freq was updated. > >>> > >>> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > >>> --- > >>> drivers/devfreq/devfreq.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > >>> index 6e80bf70e7b3..ce569bd9adfa 100644 > >>> --- a/drivers/devfreq/devfreq.c > >>> +++ b/drivers/devfreq/devfreq.c > >>> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > >>> devfreq->previous_freq = new_freq; > >>> > >>> if (devfreq->suspend_freq) > >>> - devfreq->resume_freq = cur_freq; > >>> + devfreq->resume_freq = new_freq; > >>> > >>> return err; > >>> } > >>> > >> > >> This patch fixes the previous patch[1]. So that you need to > >> add 'Fixes' tag as following: > >> > >> Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a > >> devfreq device") > >> > > > > Will add Fixes tag in next version. > > > On next version, recommend to place this patch at the first. Yes, good practice as it's a fix. Regards Aisheng > > > > >> commit 83f8ca45afbf041e312909f442128b99657d90b7 > >> Refs: v4.20-rc6-2-g83f8ca45afbf > >> Author: Lukasz Luba <lukasz.luba@arm.com> > >> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 > >> Commit: MyungJoo Ham <myungjoo.ham@samsung.com> > >> CommitDate: Tue Dec 11 11:09:47 2018 +0900 > >> > >> PM / devfreq: add support for suspend/resume of a devfreq device > >> > >> > >> -- > >> Best Regards, > >> Samsung Electronics > >> Chanwoo Choi > > > > > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics
On 3/10/21 11:43 AM, Dong Aisheng wrote: > On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: >> >> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: >>> Use the more accurate returned new_freq as resume_freq. >>> It's the same as how devfreq->previous_freq was updated. >>> >>> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> >>> --- >>> drivers/devfreq/devfreq.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >>> index 6e80bf70e7b3..ce569bd9adfa 100644 >>> --- a/drivers/devfreq/devfreq.c >>> +++ b/drivers/devfreq/devfreq.c >>> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, >>> devfreq->previous_freq = new_freq; >>> >>> if (devfreq->suspend_freq) >>> - devfreq->resume_freq = cur_freq; >>> + devfreq->resume_freq = new_freq; >>> >>> return err; >>> } >>> >> >> This patch fixes the previous patch[1]. So that you need to >> add 'Fixes' tag as following: >> >> Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a >> devfreq device") >> > > Will add Fixes tag in next version. On next version, recommend to place this patch at the first. > >> commit 83f8ca45afbf041e312909f442128b99657d90b7 >> Refs: v4.20-rc6-2-g83f8ca45afbf >> Author: Lukasz Luba <lukasz.luba@arm.com> >> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 >> Commit: MyungJoo Ham <myungjoo.ham@samsung.com> >> CommitDate: Tue Dec 11 11:09:47 2018 +0900 >> >> PM / devfreq: add support for suspend/resume of a devfreq device >> >> >> -- >> Best Regards, >> Samsung Electronics >> Chanwoo Choi > >
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 6e80bf70e7b3..ce569bd9adfa 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, devfreq->previous_freq = new_freq; if (devfreq->suspend_freq) - devfreq->resume_freq = cur_freq; + devfreq->resume_freq = new_freq; return err; }
Use the more accurate returned new_freq as resume_freq. It's the same as how devfreq->previous_freq was updated. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)