| Message ID | 1615294733-22761-12-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | PM / devfreq: a few small fixes and improvements | expand |
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > polling_ms is only used by simple ondemand governor which > this driver can't support. Drop it to avoid confusing. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/devfreq/imx8m-ddrc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c > index 0a6b7a1c829d..ecb9375aa877 100644 > --- a/drivers/devfreq/imx8m-ddrc.c > +++ b/drivers/devfreq/imx8m-ddrc.c > @@ -417,7 +417,6 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > if (ret < 0) > goto err; > > - priv->profile.polling_ms = 1000; > priv->profile.target = imx8m_ddrc_target; > priv->profile.exit = imx8m_ddrc_exit; > priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq; > You can squash this patch with patch10 because polling_ms is related to .get_dev_status.
On Wed, Mar 10, 2021 at 12:23 AM Chanwoo Choi <cwchoi00@gmail.com> wrote: > > On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > > polling_ms is only used by simple ondemand governor which > > this driver can't support. Drop it to avoid confusing. > > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/devfreq/imx8m-ddrc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c > > index 0a6b7a1c829d..ecb9375aa877 100644 > > --- a/drivers/devfreq/imx8m-ddrc.c > > +++ b/drivers/devfreq/imx8m-ddrc.c > > @@ -417,7 +417,6 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > > if (ret < 0) > > goto err; > > > > - priv->profile.polling_ms = 1000; > > priv->profile.target = imx8m_ddrc_target; > > priv->profile.exit = imx8m_ddrc_exit; > > priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq; > > > > You can squash this patch with patch10 because polling_ms > is related to .get_dev_status. Sure i can do it. Regards Aisheng > > -- > Best Regards, > Samsung Electronics > Chanwoo Choi
diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index 0a6b7a1c829d..ecb9375aa877 100644 --- a/drivers/devfreq/imx8m-ddrc.c +++ b/drivers/devfreq/imx8m-ddrc.c @@ -417,7 +417,6 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) if (ret < 0) goto err; - priv->profile.polling_ms = 1000; priv->profile.target = imx8m_ddrc_target; priv->profile.exit = imx8m_ddrc_exit; priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
polling_ms is only used by simple ondemand governor which this driver can't support. Drop it to avoid confusing. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/imx8m-ddrc.c | 1 - 1 file changed, 1 deletion(-)