diff mbox series

[v11,01/10] oid_registry: Add OIDs for ECDSA with sha224/256/384/512

Message ID 20210305205956.3594375-2-stefanb@linux.vnet.ibm.com (mailing list archive)
State New, archived
Headers show
Series Add support for x509 certs with NIST P384/256/192 keys | expand

Commit Message

Stefan Berger March 5, 2021, 8:59 p.m. UTC 
From: Stefan Berger <stefanb@linux.ibm.com>

Add OIDs for ECDSA with sha224/256/384/512.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 include/linux/oid_registry.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Jarkko Sakkinen March 10, 2021, 3:35 p.m. UTC | #1 
On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
> 
> Add OIDs for ECDSA with sha224/256/384/512.

Nit: SHA224/256/384/512 (sorry cannot help myself with these, have been
doing this way too much, consider me as a bot :-) )

> 
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
 
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko
Stefan Berger March 10, 2021, 6:38 p.m. UTC | #2 
On 3/10/21 10:35 AM, Jarkko Sakkinen wrote:
> On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Add OIDs for ECDSA with sha224/256/384/512.
> Nit: SHA224/256/384/512 (sorry cannot help myself with these, have been
> doing this way too much, consider me as a bot :-) )
>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>   
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

Jarrko,

   I applied the nit and the 4 Acked-by's.

Thank you!


    Stefan
Jarkko Sakkinen March 10, 2021, 9:41 p.m. UTC | #3 
On Wed, Mar 10, 2021 at 01:38:12PM -0500, Stefan Berger wrote:
> 
> On 3/10/21 10:35 AM, Jarkko Sakkinen wrote:
> > On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@linux.ibm.com>
> > > 
> > > Add OIDs for ECDSA with sha224/256/384/512.
> > Nit: SHA224/256/384/512 (sorry cannot help myself with these, have been
> > doing this way too much, consider me as a bot :-) )
> > 
> > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> > Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> Jarrko,
> 
>   I applied the nit and the 4 Acked-by's.
> 
> Thank you!
> 
> 
>    Stefan

Cool, thank you :-)

/Jarkko
diff mbox series

Patch

diff --git a/include/linux/oid_registry.h b/include/linux/oid_registry.h
index 4462ed2c18cd..b504e2f36b25 100644
--- a/include/linux/oid_registry.h
+++ b/include/linux/oid_registry.h
@@ -19,8 +19,12 @@ 
 enum OID {
 	OID_id_dsa_with_sha1,		/* 1.2.840.10030.4.3 */
 	OID_id_dsa,			/* 1.2.840.10040.4.1 */
-	OID_id_ecdsa_with_sha1,		/* 1.2.840.10045.4.1 */
 	OID_id_ecPublicKey,		/* 1.2.840.10045.2.1 */
+	OID_id_ecdsa_with_sha1,		/* 1.2.840.10045.4.1 */
+	OID_id_ecdsa_with_sha224,	/* 1.2.840.10045.4.3.1 */
+	OID_id_ecdsa_with_sha256,	/* 1.2.840.10045.4.3.2 */
+	OID_id_ecdsa_with_sha384,	/* 1.2.840.10045.4.3.3 */
+	OID_id_ecdsa_with_sha512,	/* 1.2.840.10045.4.3.4 */
 
 	/* PKCS#1 {iso(1) member-body(2) us(840) rsadsi(113549) pkcs(1) pkcs-1(1)} */
 	OID_rsaEncryption,		/* 1.2.840.113549.1.1.1 */