| Message ID | 20210308152501.2135937-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ee3ba5fdc630fecfc96376a219085a6b0d5ff980 |
| Headers | show |
| Series | [1/3] PCI: controller: al: select CONFIG_PCI_ECAM | expand |
Hi, > Compile-testing this driver without ECAM support results in a link > failure: > > ld.lld: error: undefined symbol: pci_ecam_map_bus > >>> referenced by pcie-al.c > >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a > > Select CONFIG_ECAM like the other drivers do. [...] Ouch. Thank you! Reviewed-by: Krzysztof Wilczyński <kw@linux.com> Krzysztof
On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Compile-testing this driver without ECAM support results in a link > failure: > > ld.lld: error: undefined symbol: pci_ecam_map_bus > >>> referenced by pcie-al.c > >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a > > Select CONFIG_ECAM like the other drivers do. Did we add these compile issues in the v5.12-rc1? I.e., are the fixes candidates for v5.12? > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 5a3032d9b844..d981a0eba99f 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -311,6 +311,7 @@ config PCIE_AL > depends on OF && (ARM64 || COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > + select PCI_ECAM > help > Say Y here to enable support of the Amazon's Annapurna Labs PCIe > controller IP on Amazon SoCs. The PCIe controller uses the DesignWare > -- > 2.29.2 >
On Wed, Mar 10, 2021 at 8:32 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > Compile-testing this driver without ECAM support results in a link > > failure: > > > > ld.lld: error: undefined symbol: pci_ecam_map_bus > > >>> referenced by pcie-al.c > > >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a > > > > Select CONFIG_ECAM like the other drivers do. > > Did we add these compile issues in the v5.12-rc1? I.e., are the fixes > candidates for v5.12? No, the bug exists but is hidden until you apply patch 3/3 because the driver is never compile tested on anything other than arm64, which turns on PCI_ECAM unconditionally. Merging all three for 5.13 is sufficient. Arnd
On Wed, Mar 10, 2021 at 10:02:55PM +0100, Arnd Bergmann wrote: > On Wed, Mar 10, 2021 at 8:32 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > > > On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > > > Compile-testing this driver without ECAM support results in a link > > > failure: > > > > > > ld.lld: error: undefined symbol: pci_ecam_map_bus > > > >>> referenced by pcie-al.c > > > >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a > > > > > > Select CONFIG_ECAM like the other drivers do. > > > > Did we add these compile issues in the v5.12-rc1? I.e., are the fixes > > candidates for v5.12? > > No, the bug exists but is hidden until you apply patch 3/3 because the > driver is never compile tested on anything other than arm64, which > turns on PCI_ECAM unconditionally. > > Merging all three for 5.13 is sufficient. I put these on pci/misc for v5.13, thanks!
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 5a3032d9b844..d981a0eba99f 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -311,6 +311,7 @@ config PCIE_AL depends on OF && (ARM64 || COMPILE_TEST) depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST + select PCI_ECAM help Say Y here to enable support of the Amazon's Annapurna Labs PCIe controller IP on Amazon SoCs. The PCIe controller uses the DesignWare