| Message ID | 20210312160622.24165-3-srivasam@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Qualcomm's lpass device tree changes for I2s dai | expand |
Hi, On Fri, Mar 12, 2021 at 8:07 AM Srinivasa Rao Mandadapu <srivasam@codeaurora.org> wrote: > > This is a trgodor variant, required to have sound node variable > for coachz specific platform. > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > index 4ad520f00485..7eaad739b6f9 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > @@ -89,6 +89,16 @@ &sn65dsi86_out { > data-lanes = <0 1 2 3>; > }; > > +&sound { > + compatible = "google,sc7180-coachz"; > + model = "sc7180-adau7002-max98357a"; > + audio-routing = "PDM_DAT", "DMIC"; > +}; > + > +&multimedia0_codec { > + sound-dai = <&adau7002>; > +}; > + Much nicer! The last nit is that "multimedia0_codec" is now sorted incorrectly. It starts with "m" so it shouldn't come after "s". Yes, I know that this rule means that these two things are no longer next to each other, but that's the rule we have right now. If it's important for you for them to sort together, I suppose you could change the label to "sound_multimedia0_codec" though that's a bit of a mouthful. I'll leave it up to you whether to rename (and keep the current ordering) or keep the name (and move the node). -Doug
Hi Doug, Thanks for your time and inputs!!! On 3/13/2021 2:58 AM, Doug Anderson wrote: > Hi, > > On Fri, Mar 12, 2021 at 8:07 AM Srinivasa Rao Mandadapu > <srivasam@codeaurora.org> wrote: >> This is a trgodor variant, required to have sound node variable >> for coachz specific platform. >> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi >> index 4ad520f00485..7eaad739b6f9 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi >> @@ -89,6 +89,16 @@ &sn65dsi86_out { >> data-lanes = <0 1 2 3>; >> }; >> >> +&sound { >> + compatible = "google,sc7180-coachz"; >> + model = "sc7180-adau7002-max98357a"; >> + audio-routing = "PDM_DAT", "DMIC"; >> +}; >> + >> +&multimedia0_codec { >> + sound-dai = <&adau7002>; >> +}; >> + > Much nicer! The last nit is that "multimedia0_codec" is now sorted > incorrectly. It starts with "m" so it shouldn't come after "s". Yes, I > know that this rule means that these two things are no longer next to > each other, but that's the rule we have right now. > > If it's important for you for them to sort together, I suppose you > could change the label to "sound_multimedia0_codec" though that's a > bit of a mouthful. I'll leave it up to you whether to rename (and keep > the current ordering) or keep the name (and move the node). > > > > -Doug I feel it's good to keep them together by changing name as you suggested. I will change accordingly and re post it.
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi index 4ad520f00485..7eaad739b6f9 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi @@ -89,6 +89,16 @@ &sn65dsi86_out { data-lanes = <0 1 2 3>; }; +&sound { + compatible = "google,sc7180-coachz"; + model = "sc7180-adau7002-max98357a"; + audio-routing = "PDM_DAT", "DMIC"; +}; + +&multimedia0_codec { + sound-dai = <&adau7002>; +}; + /* PINCTRL - modifications to sc7180-trogdor.dtsi */ &en_pp3300_dx_edp {
This is a trgodor variant, required to have sound node variable for coachz specific platform. Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)