| Message ID | 20210310160125.810157-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 575dd7ece61fa93270cb5749708b140a9c9cf947 |
| Headers | show |
| Series | [1/1] usb: cdns3: fix static checker warning. | expand |
On 21-03-10 10:01:25, Frank Li wrote: > The patch c450e48eb570: "usb: cdns3: add power lost support for > system resume" from Feb 18, 2021, leads to the following static > checker warning: > > drivers/usb/cdns3/core.c:551 cdns_resume() > error: uninitialized symbol 'ret'. > > drivers/usb/cdns3/core.c > 544 > 545 if (!role_changed) { > 546 if (cdns->role == USB_ROLE_HOST) > 547 ret = cdns_drd_host_on(cdns); > 548 else if (cdns->role == USB_ROLE_DEVICE) > 549 ret = cdns_drd_gadget_on(cdns); > > "ret" is uninitialized at else branch. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > drivers/usb/cdns3/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index 5d486c8a9d99..bb739d88179f 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -527,7 +527,7 @@ int cdns_resume(struct cdns *cdns, u8 set_active) > struct device *dev = cdns->dev; > enum usb_role real_role; > bool role_changed = false; > - int ret; > + int ret = 0; > > if (cdns_power_is_lost(cdns)) { > if (cdns->role_sw) { > -- > 2.25.1 > Hi Frank, If this issue is reported by Dan, you may add his reported-by tag. Besides, please keep your signed-of-by tag as the same with your patch author. I fixed both, you do not need to re-send.
diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 5d486c8a9d99..bb739d88179f 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -527,7 +527,7 @@ int cdns_resume(struct cdns *cdns, u8 set_active) struct device *dev = cdns->dev; enum usb_role real_role; bool role_changed = false; - int ret; + int ret = 0; if (cdns_power_is_lost(cdns)) { if (cdns->role_sw) {
The patch c450e48eb570: "usb: cdns3: add power lost support for system resume" from Feb 18, 2021, leads to the following static checker warning: drivers/usb/cdns3/core.c:551 cdns_resume() error: uninitialized symbol 'ret'. drivers/usb/cdns3/core.c 544 545 if (!role_changed) { 546 if (cdns->role == USB_ROLE_HOST) 547 ret = cdns_drd_host_on(cdns); 548 else if (cdns->role == USB_ROLE_DEVICE) 549 ret = cdns_drd_gadget_on(cdns); "ret" is uninitialized at else branch. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- drivers/usb/cdns3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)