diff mbox series

[v3,net-next,4/6] linux/etherdevice.h: misc trailing whitespace cleanup

Message ID 20210314111027.7657-5-alobakin@pm.me (mailing list archive)
State Accepted
Delegated to: Netdev Maintainers
Headers show
Series skbuff: micro-optimize flow dissection | expand

Checks

Context Check Description
netdev/apply fail Patch does not apply to net-next
netdev/tree_selection success Clearly marked for net-next

Commit Message

Alexander Lobakin March 14, 2021, 11:11 a.m. UTC
Caught by the text editor. Fix it separately from the actual changes.

Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 include/linux/etherdevice.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.30.2

Comments

Vladimir Oltean March 14, 2021, 9:04 p.m. UTC | #1
On Sun, Mar 14, 2021 at 11:11:32AM +0000, Alexander Lobakin wrote:
> Caught by the text editor. Fix it separately from the actual changes.
> 
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  include/linux/etherdevice.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index 2e5debc0373c..bcb2f81baafb 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
> @@ -11,7 +11,7 @@
>   * Authors:	Ross Biro
>   *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
>   *
> - *		Relocated to include/linux where it belongs by Alan Cox
> + *		Relocated to include/linux where it belongs by Alan Cox
>   *							<gw4pts@gw4pts.ampr.org>
>   */
>  #ifndef _LINUX_ETHERDEVICE_H
> --
> 2.30.2
> 
> 

Your mailer did something weird here, it trimmed the trailing whitespace
from the "-" line. The patch doesn't apply.
Alexander Lobakin March 15, 2021, 9:38 a.m. UTC | #2
From: Vladimir Oltean <olteanv@gmail.com>
Date: Sun, 14 Mar 2021 23:04:53 +0200

> On Sun, Mar 14, 2021 at 11:11:32AM +0000, Alexander Lobakin wrote:
> > Caught by the text editor. Fix it separately from the actual changes.
> >
> > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > ---
> >  include/linux/etherdevice.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> > index 2e5debc0373c..bcb2f81baafb 100644
> > --- a/include/linux/etherdevice.h
> > +++ b/include/linux/etherdevice.h
> > @@ -11,7 +11,7 @@
> >   * Authors:	Ross Biro
> >   *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
> >   *
> > - *		Relocated to include/linux where it belongs by Alan Cox
> > + *		Relocated to include/linux where it belongs by Alan Cox
> >   *							<gw4pts@gw4pts.ampr.org>
> >   */
> >  #ifndef _LINUX_ETHERDEVICE_H
> > --
> > 2.30.2
> >
> >
>
> Your mailer did something weird here, it trimmed the trailing whitespace
> from the "-" line. The patch doesn't apply.

It's git-send-email + ProtonMail Bridge... Seems like that's the
reason why only this series of mine was failing Patchwork
everytime.

Much thanks for finding this out!
Al
Jakub Kicinski March 15, 2021, 7 p.m. UTC | #3
On Mon, 15 Mar 2021 09:38:57 +0000 Alexander Lobakin wrote:
> From: Vladimir Oltean <olteanv@gmail.com>
> Date: Sun, 14 Mar 2021 23:04:53 +0200
> 
> > On Sun, Mar 14, 2021 at 11:11:32AM +0000, Alexander Lobakin wrote:  
> > > Caught by the text editor. Fix it separately from the actual changes.
> > >
> > > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > > ---
> > >  include/linux/etherdevice.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> > > index 2e5debc0373c..bcb2f81baafb 100644
> > > --- a/include/linux/etherdevice.h
> > > +++ b/include/linux/etherdevice.h
> > > @@ -11,7 +11,7 @@
> > >   * Authors:	Ross Biro
> > >   *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
> > >   *
> > > - *		Relocated to include/linux where it belongs by Alan Cox
> > > + *		Relocated to include/linux where it belongs by Alan Cox
> > >   *							<gw4pts@gw4pts.ampr.org>
> > >   */
> > >  #ifndef _LINUX_ETHERDEVICE_H
> > > --
> > > 2.30.2
> > >
> > >  
> >
> > Your mailer did something weird here, it trimmed the trailing whitespace
> > from the "-" line. The patch doesn't apply.  
> 
> It's git-send-email + ProtonMail Bridge... Seems like that's the
> reason why only this series of mine was failing Patchwork
> everytime.

Yup. Sorry for the lack of logs in NIPA, you can run

  git pw series apply $id

and look at the output there. That's what I do, anyway, to double check
that the patch doesn't apply so the logs are of limited use.
Alexander Lobakin March 17, 2021, 11:02 a.m. UTC | #4
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 15 Mar 2021 12:00:39 -0700

> On Mon, 15 Mar 2021 09:38:57 +0000 Alexander Lobakin wrote:
> > From: Vladimir Oltean <olteanv@gmail.com>
> > Date: Sun, 14 Mar 2021 23:04:53 +0200
> >
> > > On Sun, Mar 14, 2021 at 11:11:32AM +0000, Alexander Lobakin wrote:
> > > > Caught by the text editor. Fix it separately from the actual changes.
> > > >
> > > > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > > > ---
> > > >  include/linux/etherdevice.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> > > > index 2e5debc0373c..bcb2f81baafb 100644
> > > > --- a/include/linux/etherdevice.h
> > > > +++ b/include/linux/etherdevice.h
> > > > @@ -11,7 +11,7 @@
> > > >   * Authors:	Ross Biro
> > > >   *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
> > > >   *
> > > > - *		Relocated to include/linux where it belongs by Alan Cox
> > > > + *		Relocated to include/linux where it belongs by Alan Cox
> > > >   *							<gw4pts@gw4pts.ampr.org>
> > > >   */
> > > >  #ifndef _LINUX_ETHERDEVICE_H
> > > > --
> > > > 2.30.2
> > > >
> > > >
> > >
> > > Your mailer did something weird here, it trimmed the trailing whitespace
> > > from the "-" line. The patch doesn't apply.
> >
> > It's git-send-email + ProtonMail Bridge... Seems like that's the
> > reason why only this series of mine was failing Patchwork
> > everytime.
>
> Yup. Sorry for the lack of logs in NIPA, you can run
>
>   git pw series apply $id
>
> and look at the output there. That's what I do, anyway, to double check
> that the patch doesn't apply so the logs are of limited use.

Got it, thanks!

Al
diff mbox series

Patch

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 2e5debc0373c..bcb2f81baafb 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -11,7 +11,7 @@ 
  * Authors:	Ross Biro
  *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
  *
- *		Relocated to include/linux where it belongs by Alan Cox
+ *		Relocated to include/linux where it belongs by Alan Cox
  *							<gw4pts@gw4pts.ampr.org>
  */
 #ifndef _LINUX_ETHERDEVICE_H