mbox series

[RFC,0/3] block_dump: remove block dump

Message ID 20210313030146.2882027-1-yi.zhang@huawei.com (mailing list archive)
Headers show
Series block_dump: remove block dump | expand

Message

Zhang Yi March 13, 2021, 3:01 a.m. UTC 
Hi,

block_dump is an old debugging interface and can be replaced by
tracepoints, and we also found a deadlock issue relate to it[1]. As Jan
suggested, this patch set delete the whole block_dump feature, we can
use tracepoints to get the similar information. If someone still using
this feature cannot switch to use tracepoints or any other suggestions,
please let us know.

Thanks,
Yi.

[1]. https://lore.kernel.org/linux-fsdevel/20210305132442.GA2801131@infradead.org/T/#m385b0f84bc381d3089740e33d94f6e1b67dd06d2

zhangyi (F) (3):
  block_dump: remove block_dump feature in mark_inode_dirty()
  block_dump: remove block_dump feature
  block_dump: remove comments in docs

 .../admin-guide/laptops/laptop-mode.rst       | 11 --------
 Documentation/admin-guide/sysctl/vm.rst       |  8 ------
 block/blk-core.c                              |  9 -------
 fs/fs-writeback.c                             | 25 -------------------
 include/linux/writeback.h                     |  1 -
 kernel/sysctl.c                               |  8 ------
 mm/page-writeback.c                           |  5 ----
 7 files changed, 67 deletions(-)

Comments

Jens Axboe March 13, 2021, 3:37 a.m. UTC | #1 
On 3/12/21 8:01 PM, zhangyi (F) wrote:
> Hi,
> 
> block_dump is an old debugging interface and can be replaced by
> tracepoints, and we also found a deadlock issue relate to it[1]. As Jan
> suggested, this patch set delete the whole block_dump feature, we can
> use tracepoints to get the similar information. If someone still using
> this feature cannot switch to use tracepoints or any other suggestions,
> please let us know.

Totally agree, that's long overdue. The feature is no longer useful
and has been deprecated by much better methods. Unless anyone objects,
I'll queue this up for 5.13.
Christoph Hellwig March 15, 2021, 9:56 a.m. UTC | #2 
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Zhang Yi May 10, 2021, 1:29 a.m. UTC | #3 
On 2021/3/13 11:37, Jens Axboe wrote:
> On 3/12/21 8:01 PM, zhangyi (F) wrote:
>> Hi,
>>
>> block_dump is an old debugging interface and can be replaced by
>> tracepoints, and we also found a deadlock issue relate to it[1]. As Jan
>> suggested, this patch set delete the whole block_dump feature, we can
>> use tracepoints to get the similar information. If someone still using
>> this feature cannot switch to use tracepoints or any other suggestions,
>> please let us know.
> 
> Totally agree, that's long overdue. The feature is no longer useful
> and has been deprecated by much better methods. Unless anyone objects,
> I'll queue this up for 5.13.
> 
Hi, Jens. Could you please send these patches upstream ?

Thanks,
Yi.
Jens Axboe May 10, 2021, 3:21 p.m. UTC | #4 
On 3/12/21 8:01 PM, zhangyi (F) wrote:
> Hi,
> 
> block_dump is an old debugging interface and can be replaced by
> tracepoints, and we also found a deadlock issue relate to it[1]. As Jan
> suggested, this patch set delete the whole block_dump feature, we can
> use tracepoints to get the similar information. If someone still using
> this feature cannot switch to use tracepoints or any other suggestions,
> please let us know.

Applied for 5.14, thanks.