[0/3] drm/i915: Drop legacy IOCTLs on new HW

Message

Jason Ekstrand March 15, 2021, 2:34 p.m. UTC

These three patches exist to clean up some of our IOCTL mess in i915.
We've got more clean-up we should do eventually, but these are some of the
easiest to drop and most egregious cases.

Test-with: [e-mail]

Ashutosh Dixit (1):
  drm/i915: Disable pread/pwrite ioctl's for future platforms (v3)

Jason Ekstrand (2):
  drm/i915/gem: Drop legacy execbuffer support (v2)
  drm/i915/gem: Drop relocation support on all new hardware (v5)

 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 113 ++----------------
 drivers/gpu/drm/i915/gem/i915_gem_ioctls.h    |   2 -
 drivers/gpu/drm/i915/i915_drv.c               |   2 +-
 drivers/gpu/drm/i915/i915_gem.c               |  14 +++
 include/uapi/drm/i915_drm.h                   |   1 +
 5 files changed, 26 insertions(+), 106 deletions(-)

Comments

Dixit, Ashutosh March 16, 2021, 5:31 a.m. UTC | #1

On Mon, 15 Mar 2021 07:34:25 -0700, Jason Ekstrand wrote:
>
> These three patches exist to clean up some of our IOCTL mess in i915.
> We've got more clean-up we should do eventually, but these are some of the
> easiest to drop and most egregious cases.
>
> Test-with: [e-mail]

Hi Jason,

Sorry the above IGT build is too old and has been discarded so no tests
were running on actual HW as is mentioned here:

https://intel-gfx-ci.01.org/test-with.html

I resubmitted the IGT patch today so we have a newer IGT build and have
just resubmitted this series with that IGT build. There are no other
changes with the actual patches themselves.

Thanks.
--
Ashutosh



>
> Ashutosh Dixit (1):
>   drm/i915: Disable pread/pwrite ioctl's for future platforms (v3)
>
> Jason Ekstrand (2):
>   drm/i915/gem: Drop legacy execbuffer support (v2)
>   drm/i915/gem: Drop relocation support on all new hardware (v5)
>
>  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 113 ++----------------
>  drivers/gpu/drm/i915/gem/i915_gem_ioctls.h    |   2 -
>  drivers/gpu/drm/i915/i915_drv.c               |   2 +-
>  drivers/gpu/drm/i915/i915_gem.c               |  14 +++
>  include/uapi/drm/i915_drm.h                   |   1 +
>  5 files changed, 26 insertions(+), 106 deletions(-)
>
> --
> 2.29.2
>
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Jason Ekstrand March 17, 2021, 11:40 p.m. UTC | #2

These patches clean up some of our uAPI mess in i915.  The first patch
drops legacy execbuffer support which hasn't been used in 10 years.  The
next two drop some legacy ioctls on new platforms.  The last two drop APIs
which have never been used by userspace and shouldn't have landed in i915
in the first place.

Test-with: [e-mail]

Cc: Daniel Vetter <[e-mail]>
Cc: Dave Airlie <[e-mail]>

Ashutosh Dixit (1):
  drm/i915: Disable pread/pwrite ioctl's for future platforms (v3)

Jason Ekstrand (4):
  drm/i915/gem: Drop legacy execbuffer support (v2)
  drm/i915/gem: Drop relocation support on all new hardware (v6)
  drm/i915: Drop the CONTEXT_CLONE API
  drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

 drivers/gpu/drm/i915/Makefile                 |   1 -
 drivers/gpu/drm/i915/gem/i915_gem_context.c   | 311 +-----------------
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 107 +-----
 drivers/gpu/drm/i915/gem/i915_gem_ioctls.h    |   2 -
 drivers/gpu/drm/i915/gt/intel_context_param.c |  63 ----
 drivers/gpu/drm/i915/gt/intel_context_param.h |  14 -
 drivers/gpu/drm/i915/gt/intel_lrc.c           |   1 -
 drivers/gpu/drm/i915/i915_drv.c               |   2 +-
 drivers/gpu/drm/i915/i915_gem.c               |  14 +
 include/uapi/drm/i915_drm.h                   |  37 +--
 10 files changed, 41 insertions(+), 511 deletions(-)
 delete mode 100644 drivers/gpu/drm/i915/gt/intel_context_param.c
 delete mode 100644 drivers/gpu/drm/i915/gt/intel_context_param.h