mbox series

[v2,0/3] mmc: renesas_sdhi: reset via reset controller

Message ID 20210315145938.58565-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series mmc: renesas_sdhi: reset via reset controller | expand

Message

Wolfram Sang March 15, 2021, 2:59 p.m. UTC 
This series enables SDHI to be reset via a reset controller.
Please let me know about your (and BSP team's) thoughts.
The series is based on mmc/next and tested on Salvator-XS with R-Car H3
ES2.0 with what I think I can do locally here.

Changes since v1:
* Niklas tag added to patch 1 (thanks!)
* new patch 2 to factor out SCC reset and make intentions clearer
  (thanks to Shimoda-san for the review!)
* patch 3 re-inits now the SD clock again after the hard reset

Wolfram Sang (3):
  mmc: tmio: abort DMA before reset
  mmc: renesas_sdhi: break SCC reset into own function
  mmc: renesas_sdhi: do hard reset if possible

 drivers/mmc/host/Kconfig             |  1 +
 drivers/mmc/host/renesas_sdhi.h      |  2 ++
 drivers/mmc/host/renesas_sdhi_core.c | 35 +++++++++++++++++++++-------
 drivers/mmc/host/tmio_mmc_core.c     |  4 ++--
 4 files changed, 32 insertions(+), 10 deletions(-)

Comments

Yoshihiro Shimoda March 16, 2021, 6:38 a.m. UTC | #1 
Hi Wolfram-san,

> From: Wolfram Sang, Sent: Tuesday, March 16, 2021 12:00 AM
> 
> This series enables SDHI to be reset via a reset controller.
> Please let me know about your (and BSP team's) thoughts.
> The series is based on mmc/next and tested on Salvator-XS with R-Car H3
> ES2.0 with what I think I can do locally here.

Thank you for the patches!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Also, I tested on R-Car H3 ES3.0 and I didn't observe any regression.
So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda