| Message ID | 20210303081158.684532-4-steen.hegelund@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Adding the Sparx5 Switch Reset Driver | expand |
On 03/03/2021 09:11:58+0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 380281f312d8..dc3ada5cf9fc 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -132,9 +132,12 @@ mux: mux-controller { > }; > }; > > - reset@611010008 { > - compatible = "microchip,sparx5-chip-reset"; > + reset: reset-controller@611010008 { > + compatible = "microchip,sparx5-switch-reset"; > reg = <0x6 0x11010008 0x4>; > + reg-names = "gcb"; > + #reset-cells = <1>; > + cpu-syscon = <&cpu_ctrl>; > }; > > uart0: serial@600100000 { > -- > 2.30.1 >
On Wed, Mar 03, 2021 at 09:11:58AM +0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. This still looks like an incompatible change with no explanation. What happens on an old kernel that expects "microchip,sparx5-chip-reset" and doesn't understand "microchip,sparx5-switch-reset"? > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 380281f312d8..dc3ada5cf9fc 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -132,9 +132,12 @@ mux: mux-controller { > }; > }; > > - reset@611010008 { > - compatible = "microchip,sparx5-chip-reset"; > + reset: reset-controller@611010008 { > + compatible = "microchip,sparx5-switch-reset"; > reg = <0x6 0x11010008 0x4>; > + reg-names = "gcb"; > + #reset-cells = <1>; > + cpu-syscon = <&cpu_ctrl>; > }; > > uart0: serial@600100000 { > -- > 2.30.1 >
Hi Rob, On Mon, 2021-03-08 at 12:59 -0700, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Mar 03, 2021 at 09:11:58AM +0100, Steen Hegelund wrote: > > This provides reset driver support for the Microchip Sparx5 PCB134 > > and > > PCB135 reference boards. > > This still looks like an incompatible change with no explanation. > > What happens on an old kernel that expects "microchip,sparx5-chip- > reset" > and doesn't understand "microchip,sparx5-switch-reset"? Sorry about forgetting that item. I will add a note to say that this is an incompatible change. In practice, I do not think the reset driver has really been taken into use yet. > > > > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 380281f312d8..dc3ada5cf9fc 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -132,9 +132,12 @@ mux: mux-controller { > > }; > > }; > > > > - reset@611010008 { > > - compatible = "microchip,sparx5-chip-reset"; > > + reset: reset-controller@611010008 { > > + compatible = "microchip,sparx5-switch-reset"; > > reg = <0x6 0x11010008 0x4>; > > + reg-names = "gcb"; > > + #reset-cells = <1>; > > + cpu-syscon = <&cpu_ctrl>; > > }; > > > > uart0: serial@600100000 { > > -- > > 2.30.1 > >
diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 380281f312d8..dc3ada5cf9fc 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -132,9 +132,12 @@ mux: mux-controller { }; }; - reset@611010008 { - compatible = "microchip,sparx5-chip-reset"; + reset: reset-controller@611010008 { + compatible = "microchip,sparx5-switch-reset"; reg = <0x6 0x11010008 0x4>; + reg-names = "gcb"; + #reset-cells = <1>; + cpu-syscon = <&cpu_ctrl>; }; uart0: serial@600100000 {
This provides reset driver support for the Microchip Sparx5 PCB134 and PCB135 reference boards. Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)