| Message ID | 20210316134059.2377081-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: PINCTRL_ROCKCHIP should depend on ARCH_ROCKCHIP | expand |
Am Dienstag, 16. März 2021, 14:40:59 CET schrieb Geert Uytterhoeven: > The Rockchip GPIO and pin control modules are only present on Rockchip > SoCs. Hence add a dependency on ARCH_ROCKCHIP, to prevent asking the > user about this driver when configuring a kernel without Rockchip > platform support. > > Note that before, the PINCTRL_ROCKCHIP symbol was not visible, and > automatically selected when needed. By making it tristate and > user-selectable, it became visible for everyone. > > Fixes: be786ac5a6c4bf4e ("pinctrl: rockchip: make driver be tristate module") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On Tue, Mar 16, 2021 at 2:41 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Rockchip GPIO and pin control modules are only present on Rockchip > SoCs. Hence add a dependency on ARCH_ROCKCHIP, to prevent asking the > user about this driver when configuring a kernel without Rockchip > platform support. > > Note that before, the PINCTRL_ROCKCHIP symbol was not visible, and > automatically selected when needed. By making it tristate and > user-selectable, it became visible for everyone. > > Fixes: be786ac5a6c4bf4e ("pinctrl: rockchip: make driver be tristate module") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Patch applied. I saw this was causing issues on S390. Yours, Linus Walleij
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index cfde05914abf7260..2a30b26fb30deef5 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -209,6 +209,7 @@ config PINCTRL_OXNAS config PINCTRL_ROCKCHIP tristate "Rockchip gpio and pinctrl driver" + depends on ARCH_ROCKCHIP || COMPILE_TEST depends on OF select GPIOLIB select PINMUX
The Rockchip GPIO and pin control modules are only present on Rockchip SoCs. Hence add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this driver when configuring a kernel without Rockchip platform support. Note that before, the PINCTRL_ROCKCHIP symbol was not visible, and automatically selected when needed. By making it tristate and user-selectable, it became visible for everyone. Fixes: be786ac5a6c4bf4e ("pinctrl: rockchip: make driver be tristate module") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)