mbox series

[V2,0/6] PM / devfreq: a few small fixes and improvements

Message ID 1616468359-14513-1-git-send-email-aisheng.dong@nxp.com (mailing list archive)
Headers show
Series PM / devfreq: a few small fixes and improvements | expand

Message

Aisheng Dong March 23, 2021, 2:59 a.m. UTC
A few small fixes and improvements

ChangeLog:
v1->v2:
 * squash a few patches
 * rebase to devfreq-testing
 * drop two patches which are already in devfreq-next

Dong Aisheng (6):
  PM / devfreq: fix build error when DEVFREQ_GOV_PASSIVE enabled
  PM / devfreq: Use more accurate returned new_freq as resume_freq
  PM / devfreq: Remove the invalid description for get_target_freq
  PM / devfreq: bail out early if no freq changes in devfreq_set_target
  PM / devfreq: governor: optimize simpleondemand get_target_freq
  PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status

 Documentation/ABI/testing/sysfs-class-devfreq |  5 +--
 drivers/devfreq/devfreq.c                     | 37 +++++++------------
 drivers/devfreq/governor.h                    |  2 -
 drivers/devfreq/governor_simpleondemand.c     | 31 ++++++++++------
 drivers/devfreq/imx8m-ddrc.c                  | 14 -------
 5 files changed, 35 insertions(+), 54 deletions(-)

Comments

Dong Aisheng March 23, 2021, 3:25 a.m. UTC | #1
Hi Chanwoo,

On Tue, Mar 23, 2021 at 11:13 AM Dong Aisheng <aisheng.dong@nxp.com> wrote:
>
> A few small fixes and improvements
>
> ChangeLog:
> v1->v2:
>  * squash a few patches
>  * rebase to devfreq-testing

I have to rebase to devfreq-testing instead of devfreq-next because
below two patches
only exist in devfreq-testing.
5cc75e9252e9 (devfreq/devfreq-testing) PM / devfreq: Add
devfreq_transitions debugfs file
dc9e557845c1 PM / devfreq: Add new up_threshold and down_differential
sysfs attrs
My patch 5 needs change based on it according to your suggestion. So i have to
rebase to that branch.

However, i found devfreq-testing can't build with GOV_PASSVIE enabled.
Patch 1 fixed it. You can squash to the original one when apply.

Please help take a look at this new series.
Thanks

Regards
Aisheng

>  * drop two patches which are already in devfreq-next
>
> Dong Aisheng (6):
>   PM / devfreq: fix build error when DEVFREQ_GOV_PASSIVE enabled
>   PM / devfreq: Use more accurate returned new_freq as resume_freq
>   PM / devfreq: Remove the invalid description for get_target_freq
>   PM / devfreq: bail out early if no freq changes in devfreq_set_target
>   PM / devfreq: governor: optimize simpleondemand get_target_freq
>   PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status
>
>  Documentation/ABI/testing/sysfs-class-devfreq |  5 +--
>  drivers/devfreq/devfreq.c                     | 37 +++++++------------
>  drivers/devfreq/governor.h                    |  2 -
>  drivers/devfreq/governor_simpleondemand.c     | 31 ++++++++++------
>  drivers/devfreq/imx8m-ddrc.c                  | 14 -------
>  5 files changed, 35 insertions(+), 54 deletions(-)
>
> --
> 2.25.1
>
Chanwoo Choi March 23, 2021, 4:11 a.m. UTC | #2
Hi,

On 3/23/21 12:25 PM, Dong Aisheng wrote:
> Hi Chanwoo,
> 
> On Tue, Mar 23, 2021 at 11:13 AM Dong Aisheng <aisheng.dong@nxp.com> wrote:
>>
>> A few small fixes and improvements
>>
>> ChangeLog:
>> v1->v2:
>>  * squash a few patches
>>  * rebase to devfreq-testing
> 
> I have to rebase to devfreq-testing instead of devfreq-next because
> below two patches
> only exist in devfreq-testing.
> 5cc75e9252e9 (devfreq/devfreq-testing) PM / devfreq: Add
> devfreq_transitions debugfs file
> dc9e557845c1 PM / devfreq: Add new up_threshold and down_differential
> sysfs attrs
> My patch 5 needs change based on it according to your suggestion. So i have to
> rebase to that branch.
> 
> However, i found devfreq-testing can't build with GOV_PASSVIE enabled.
> Patch 1 fixed it. You can squash to the original one when apply.
> 
> Please help take a look at this new series.

Please rebase your patches either devfreq-next or linux-next.git
Because devfreq-testing branch is not official. 

> Thanks
> 
> Regards
> Aisheng
> 
>>  * drop two patches which are already in devfreq-next
>>
>> Dong Aisheng (6):
>>   PM / devfreq: fix build error when DEVFREQ_GOV_PASSIVE enabled
>>   PM / devfreq: Use more accurate returned new_freq as resume_freq
>>   PM / devfreq: Remove the invalid description for get_target_freq
>>   PM / devfreq: bail out early if no freq changes in devfreq_set_target
>>   PM / devfreq: governor: optimize simpleondemand get_target_freq
>>   PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status
>>
>>  Documentation/ABI/testing/sysfs-class-devfreq |  5 +--
>>  drivers/devfreq/devfreq.c                     | 37 +++++++------------
>>  drivers/devfreq/governor.h                    |  2 -
>>  drivers/devfreq/governor_simpleondemand.c     | 31 ++++++++++------
>>  drivers/devfreq/imx8m-ddrc.c                  | 14 -------
>>  5 files changed, 35 insertions(+), 54 deletions(-)
>>
>> --
>> 2.25.1
>>
> 
>
Aisheng Dong March 23, 2021, 6:11 a.m. UTC | #3
> From: Chanwoo Choi <cw00.choi@samsung.com>
> Sent: Tuesday, March 23, 2021 12:11 PM
> 
> Hi,
> 
> On 3/23/21 12:25 PM, Dong Aisheng wrote:
> > Hi Chanwoo,
> >
> > On Tue, Mar 23, 2021 at 11:13 AM Dong Aisheng <aisheng.dong@nxp.com>
> wrote:
> >>
> >> A few small fixes and improvements
> >>
> >> ChangeLog:
> >> v1->v2:
> >>  * squash a few patches
> >>  * rebase to devfreq-testing
> >
> > I have to rebase to devfreq-testing instead of devfreq-next because
> > below two patches only exist in devfreq-testing.
> > 5cc75e9252e9 (devfreq/devfreq-testing) PM / devfreq: Add
> > devfreq_transitions debugfs file
> > dc9e557845c1 PM / devfreq: Add new up_threshold and down_differential
> > sysfs attrs My patch 5 needs change based on it according to your
> > suggestion. So i have to rebase to that branch.
> >
> > However, i found devfreq-testing can't build with GOV_PASSVIE enabled.
> > Patch 1 fixed it. You can squash to the original one when apply.
> >
> > Please help take a look at this new series.
> 
> Please rebase your patches either devfreq-next or linux-next.git Because
> devfreq-testing branch is not official.

Okay, then how about the patch 5 below?
[PATCH V2 5/6] PM / devfreq: governor: optimize simpleondemand get_target_freq

Should I also rebase it to devfreq-next or drop it first and then resend when your patch
merged into mainline?
https://patchwork.kernel.org/project/linux-arm-kernel/patch/1615294733-22761-10-git-send-email-aisheng.dong@nxp.com/

Regards
Aisheng

> 
> > Thanks
> >
> > Regards
> > Aisheng
> >
> >>  * drop two patches which are already in devfreq-next
> >>
> >> Dong Aisheng (6):
> >>   PM / devfreq: fix build error when DEVFREQ_GOV_PASSIVE enabled
> >>   PM / devfreq: Use more accurate returned new_freq as resume_freq
> >>   PM / devfreq: Remove the invalid description for get_target_freq
> >>   PM / devfreq: bail out early if no freq changes in devfreq_set_target
> >>   PM / devfreq: governor: optimize simpleondemand get_target_freq
> >>   PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status
> >>
> >>  Documentation/ABI/testing/sysfs-class-devfreq |  5 +--
> >>  drivers/devfreq/devfreq.c                     | 37 +++++++------------
> >>  drivers/devfreq/governor.h                    |  2 -
> >>  drivers/devfreq/governor_simpleondemand.c     | 31 ++++++++++------
> >>  drivers/devfreq/imx8m-ddrc.c                  | 14 -------
> >>  5 files changed, 35 insertions(+), 54 deletions(-)
> >>
> >> --
> >> 2.25.1
> >>
> >
> >
> 
> 
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
Chanwoo Choi March 23, 2021, 7:26 a.m. UTC | #4
Hi,

On 3/23/21 3:11 PM, Aisheng Dong wrote:
>> From: Chanwoo Choi <cw00.choi@samsung.com>
>> Sent: Tuesday, March 23, 2021 12:11 PM
>>
>> Hi,
>>
>> On 3/23/21 12:25 PM, Dong Aisheng wrote:
>>> Hi Chanwoo,
>>>
>>> On Tue, Mar 23, 2021 at 11:13 AM Dong Aisheng <aisheng.dong@nxp.com>
>> wrote:
>>>>
>>>> A few small fixes and improvements
>>>>
>>>> ChangeLog:
>>>> v1->v2:
>>>>  * squash a few patches
>>>>  * rebase to devfreq-testing
>>>
>>> I have to rebase to devfreq-testing instead of devfreq-next because
>>> below two patches only exist in devfreq-testing.
>>> 5cc75e9252e9 (devfreq/devfreq-testing) PM / devfreq: Add
>>> devfreq_transitions debugfs file
>>> dc9e557845c1 PM / devfreq: Add new up_threshold and down_differential
>>> sysfs attrs My patch 5 needs change based on it according to your
>>> suggestion. So i have to rebase to that branch.
>>>
>>> However, i found devfreq-testing can't build with GOV_PASSVIE enabled.
>>> Patch 1 fixed it. You can squash to the original one when apply.
>>>
>>> Please help take a look at this new series.
>>
>> Please rebase your patches either devfreq-next or linux-next.git Because
>> devfreq-testing branch is not official.
> 
> Okay, then how about the patch 5 below?
> [PATCH V2 5/6] PM / devfreq: governor: optimize simpleondemand get_target_freq
> 
> Should I also rebase it to devfreq-next or drop it first and then resend when your patch
> merged into mainline?

Yes. Thanks.

[snip]