| Message ID | 20210207190425.38107-7-chaitanya.kulkarni@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | use core page calls instead of kmaps | expand |
On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > --- > fs/ext4/verity.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Hi, were you expecting to have file system maintainers take these patches into their own trees? The ext4 patches look good, and unless you have any objections, I can take them through the ext4 tree. Thanks, - Ted
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote: > On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote: > > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > > --- > > fs/ext4/verity.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > Hi, were you expecting to have file system maintainers take these > patches into their own trees? The ext4 patches look good, and unless > you have any objections, I can take them through the ext4 tree. I think going through the ext4 tree would be fine. However, there was a fix needed in patch 2/8. Chaitanya was a V1 sent? Ira
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote: > On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote: > > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > > --- > > fs/ext4/verity.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > Hi, were you expecting to have file system maintainers take these > patches into their own trees? The ext4 patches look good, and unless > you have any objections, I can take them through the ext4 tree. I should have sent the lore link to the fix: https://lore.kernel.org/linux-f2fs-devel/BYAPR04MB496564B786E293FDA21D06E6868F9@BYAPR04MB4965.namprd04.prod.outlook.com/ Sorry, Ira
diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c index c8e07f8a792d..cc4b046490b0 100644 --- a/fs/ext4/verity.c +++ b/fs/ext4/verity.c @@ -77,7 +77,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, PAGE_SIZE - offset_in_page(pos)); struct page *page; void *fsdata; - void *addr; int res; res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0, @@ -85,9 +84,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, if (res) return res; - addr = kmap_atomic(page); - memcpy(addr + offset_in_page(pos), buf, n); - kunmap_atomic(addr); + memcpy_to_page(page, offset_in_page(pos), buf, n); res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n, page, fsdata);
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- fs/ext4/verity.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)