| Message ID | 20210329112819.64043-3-s.riedmueller@phytec.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing | expand |
On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller <s.riedmueller@phytec.de> wrote: > > Setting the vmmc supplies is crucial since otherwise the supplying > regulators get disabled and the SD interfaces are no longer powered > which leads to system failures if the system is booted from that SD > interface. It seems that this deserves a Fixes tag. Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hi Fabio, On Mon, 2021-03-29 at 08:34 -0300, Fabio Estevam wrote: > On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller > <s.riedmueller@phytec.de> wrote: > > Setting the vmmc supplies is crucial since otherwise the supplying > > regulators get disabled and the SD interfaces are no longer powered > > which leads to system failures if the system is booted from that SD > > interface. > > It seems that this deserves a Fixes tag. I think this must be broken for some time now. My guess is that it broke when the PMIC support for the SOM was added. So I can add a fixes tag for that commit. Thanks, Stefan > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi index 995e99952aca..3ab12aa2a615 100644 --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi @@ -433,6 +433,7 @@ &usdhc2 { pinctrl-0 = <&pinctrl_usdhc2>; cd-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; wp-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; + vmmc-supply = <&vdd_sd1_reg>; status = "disabled"; }; @@ -442,5 +443,6 @@ &usdhc3 { &pinctrl_usdhc3_cdwp>; cd-gpios = <&gpio1 27 GPIO_ACTIVE_LOW>; wp-gpios = <&gpio1 29 GPIO_ACTIVE_HIGH>; + vmmc-supply = <&vdd_sd0_reg>; status = "disabled"; };
Setting the vmmc supplies is crucial since otherwise the supplying regulators get disabled and the SD interfaces are no longer powered which leads to system failures if the system is booted from that SD interface. Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> --- arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 2 ++ 1 file changed, 2 insertions(+)