| Message ID | 20210326203807.105754-20-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers | expand |
Hey Lyude, This patch looks good to me. Reviewed-by: Robert Foss <robert.foss@linaro.org> On Fri, 26 Mar 2021 at 21:40, Lyude Paul <lyude@redhat.com> wrote: > > Checkpatch was complaining about this - there's no need for us to print > errors when kzalloc() fails, as kzalloc() will already WARN for us. So, > let's fix that before converting things to make checkpatch happy. > > Signed-off-by: Lyude Paul <lyude@redhat.com> > Cc: Robert Foss <robert.foss@linaro.org> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index ec2285595c33..74c420f5f204 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -4113,10 +4113,9 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr) > return 0; > > up_req = kzalloc(sizeof(*up_req), GFP_KERNEL); > - if (!up_req) { > - DRM_ERROR("Not enough memory to process MST up req\n"); > + if (!up_req) > return -ENOMEM; > - } > + > INIT_LIST_HEAD(&up_req->next); > > drm_dp_sideband_parse_req(&mgr->up_req_recv, &up_req->msg); > -- > 2.30.2 >
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index ec2285595c33..74c420f5f204 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -4113,10 +4113,9 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr) return 0; up_req = kzalloc(sizeof(*up_req), GFP_KERNEL); - if (!up_req) { - DRM_ERROR("Not enough memory to process MST up req\n"); + if (!up_req) return -ENOMEM; - } + INIT_LIST_HEAD(&up_req->next); drm_dp_sideband_parse_req(&mgr->up_req_recv, &up_req->msg);
Checkpatch was complaining about this - there's no need for us to print errors when kzalloc() fails, as kzalloc() will already WARN for us. So, let's fix that before converting things to make checkpatch happy. Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: Robert Foss <robert.foss@linaro.org> --- drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)