| Message ID | 20210331122709.3935521-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 889cb0d43d18ed348971e49378ed6a63e3a4745e |
| Headers | show |
| Series | [-next] remoteproc: imx_rproc: fix build error without CONFIG_MAILBOX | expand |
On Wed, Mar 31, 2021 at 12:27:09PM +0000, Wei Yongjun wrote: > Fix build error when CONFIG_MAILBOX is not set: > > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_kick': > imx_rproc.c:(.text+0x328): undefined reference to `mbox_send_message' > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_probe': > imx_rproc.c:(.text+0x52c): undefined reference to `mbox_request_channel_byname' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x548): undefined reference to `mbox_request_channel_byname' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x76c): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x774): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x7c4): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_remove': > imx_rproc.c:(.text+0x86c): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x874): undefined reference to `mbox_free_channel' > make: *** [Makefile:1292: vmlinux] Error 1 > > Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/remoteproc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index 7cf3d1b40c55..e68fcedc999c 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -26,6 +26,7 @@ config REMOTEPROC_CDEV > config IMX_REMOTEPROC > tristate "i.MX remoteproc support" > depends on ARCH_MXC > + select MAILBOX > help > Say y here to support iMX's remote processors via the remote > processor framework. >
Hello: This patch was applied to andersson/remoteproc.git (refs/heads/for-next): On Wed, 31 Mar 2021 12:27:09 +0000 you wrote: > Fix build error when CONFIG_MAILBOX is not set: > > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_kick': > imx_rproc.c:(.text+0x328): undefined reference to `mbox_send_message' > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_probe': > imx_rproc.c:(.text+0x52c): undefined reference to `mbox_request_channel_byname' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x548): undefined reference to `mbox_request_channel_byname' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x76c): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x774): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x7c4): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_remove': > imx_rproc.c:(.text+0x86c): undefined reference to `mbox_free_channel' > arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x874): undefined reference to `mbox_free_channel' > make: *** [Makefile:1292: vmlinux] Error 1 > > [...] Here is the summary with links: - [-next] remoteproc: imx_rproc: fix build error without CONFIG_MAILBOX https://git.kernel.org/andersson/remoteproc/c/889cb0d43d18 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index 7cf3d1b40c55..e68fcedc999c 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -26,6 +26,7 @@ config REMOTEPROC_CDEV config IMX_REMOTEPROC tristate "i.MX remoteproc support" depends on ARCH_MXC + select MAILBOX help Say y here to support iMX's remote processors via the remote processor framework.
Fix build error when CONFIG_MAILBOX is not set: arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_kick': imx_rproc.c:(.text+0x328): undefined reference to `mbox_send_message' arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_probe': imx_rproc.c:(.text+0x52c): undefined reference to `mbox_request_channel_byname' arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x548): undefined reference to `mbox_request_channel_byname' arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x76c): undefined reference to `mbox_free_channel' arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x774): undefined reference to `mbox_free_channel' arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x7c4): undefined reference to `mbox_free_channel' arm-linux-gnueabi-ld: drivers/remoteproc/imx_rproc.o: in function `imx_rproc_remove': imx_rproc.c:(.text+0x86c): undefined reference to `mbox_free_channel' arm-linux-gnueabi-ld: imx_rproc.c:(.text+0x874): undefined reference to `mbox_free_channel' make: *** [Makefile:1292: vmlinux] Error 1 Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/remoteproc/Kconfig | 1 + 1 file changed, 1 insertion(+)