| Message ID | 20210325230938.30752-1-joao.m.martins@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mm, sparse-vmemmap: Introduce compound pagemaps | expand |
On 3/25/21 11:09 PM, Joao Martins wrote: [...] > Patch 11: Optimize grabbing page refcount changes given that we > are working with compound pages i.e. we do 1 increment to the head > page for a given set of N subpages compared as opposed to N individual writes. > {get,pin}_user_pages_fast() for zone_device with compound pagemap consequently > improves considerably with DRAM stored struct pages. It also *greatly* > improves pinning with altmap. Results with gup_test: > > before after > (16G get_user_pages_fast 2M page size) ~59 ms -> ~6.1 ms > (16G pin_user_pages_fast 2M page size) ~87 ms -> ~6.2 ms > (16G get_user_pages_fast altmap 2M page size) ~494 ms -> ~9 ms > (16G pin_user_pages_fast altmap 2M page size) ~494 ms -> ~10 ms > > altmap performance gets specially interesting when pinning a pmem dimm: > > before after > (128G get_user_pages_fast 2M page size) ~492 ms -> ~49 ms > (128G pin_user_pages_fast 2M page size) ~493 ms -> ~50 ms > (128G get_user_pages_fast altmap 2M page size) ~3.91 ms -> ~70 ms > (128G pin_user_pages_fast altmap 2M page size) ~3.97 ms -> ~74 ms > Quick correction: These last two 3.91 and 3.97 on the left column are in *seconds* not milliseconds. By mistake I added an extra 'm'. Sorry about that. > The unpinning improvement patches are in mmotm/linux-next so removed from this > series. > > I have deferred the __get_user_pages() patch to outside this series > (https://lore.kernel.org/linux-mm/20201208172901.17384-11-joao.m.martins@oracle.com/), > as I found an simpler way to address it and that is also applicable to > THP. But will submit that as a follow up of this. > > Patches apply on top of linux-next tag next-20210325 (commit b4f20b70784a). > > Comments and suggestions very much appreciated! > > Changelog, > > RFC -> v1: > (New patches 1-3, 5-8 but the diffstat is that different) > * Fix hwpoisoning of devmap pages reported by Jane (Patch 1 is new in v1) > * Fix/Massage commit messages to be more clear and remove the 'we' occurences (Dan, John, Matthew) I just noticed that I haven't fully removed the 'we' occurrences. Patches 7 and 8 had their commit messages rewritten and I mistakenly re-introduced remnants of 'we'. I will have it fixed for (v2) albeit I'll still wait for comments on this series before following up. > * Use pfn_align to be clear it's nr of pages for @align value (John, Dan) > * Add two helpers pgmap_align() and pgmap_pfn_align() as accessors of pgmap->align; > * Remove the gup_device_compound_huge special path and have the same code > work both ways while special casing when devmap page is compound (Jason, John) > * Avoid usage of vmemmap_populate_basepages() and introduce a first class > loop that doesn't care about passing an altmap for memmap reuse. (Dan) > * Completely rework the vmemmap_populate_compound() to avoid the sparse_add_section > hack into passing block across sparse_add_section calls. It's a lot easier to > follow and more explicit in what it does. > * Replace the vmemmap refactoring with adding a @pgmap argument and moving > parts of the vmemmap_populate_base_pages(). (Patch 5 and 6 are new as a result) > * Add PMD tail page vmemmap area reuse for 1GB pages. (Patch 8 is new) > * Improve memmap_init_zone_device() to initialize compound pages when > struct pages are cache warm. That lead to a even further speed up further > from RFC series from 190ms -> 80-120ms. Patches 2 and 3 are the new ones > as a result (Dan) > * Remove PGMAP_COMPOUND and use @align as the property to detect whether > or not to reuse vmemmap areas (Dan) > > Thanks, > Joao > > Joao Martins (11): > memory-failure: fetch compound_head after pgmap_pfn_valid() > mm/page_alloc: split prep_compound_page into head and tail subparts > mm/page_alloc: refactor memmap_init_zone_device() page init > mm/memremap: add ZONE_DEVICE support for compound pages > mm/sparse-vmemmap: add a pgmap argument to section activation > mm/sparse-vmemmap: refactor vmemmap_populate_basepages() > mm/sparse-vmemmap: populate compound pagemaps > mm/sparse-vmemmap: use hugepages for PUD compound pagemaps > mm/page_alloc: reuse tail struct pages for compound pagemaps > device-dax: compound pagemap support > mm/gup: grab head page refcount once for group of subpages > > drivers/dax/device.c | 58 +++++++-- > include/linux/memory_hotplug.h | 5 +- > include/linux/memremap.h | 13 ++ > include/linux/mm.h | 8 +- > mm/gup.c | 52 +++++--- > mm/memory-failure.c | 2 + > mm/memory_hotplug.c | 3 +- > mm/memremap.c | 9 +- > mm/page_alloc.c | 126 +++++++++++++------ > mm/sparse-vmemmap.c | 221 +++++++++++++++++++++++++++++---- > mm/sparse.c | 24 ++-- > 11 files changed, 406 insertions(+), 115 deletions(-) >
Hey, This series, attempts at minimizing 'struct page' overhead by pursuing a similar approach as Muchun Song series "Free some vmemmap pages of hugetlb page"[0] but applied to devmap/ZONE_DEVICE. [0] https://lore.kernel.org/linux-mm/20210308102807.59745-1-songmuchun@bytedance.com/ The link above describes it quite nicely, but the idea is to reuse tail page vmemmap areas, particular the area which only describes tail pages. So a vmemmap page describes 64 struct pages, and the first page for a given ZONE_DEVICE vmemmap would contain the head page and 63 tail pages. The second vmemmap page would contain only tail pages, and that's what gets reused across the rest of the subsection/section. The bigger the page size, the bigger the savings (2M hpage -> save 6 vmemmap pages; 1G hpage -> save 4094 vmemmap pages). This series also takes one step further on 1GB pages and *also* reuse PMD pages which only contain tail pages which allows to keep parity with current hugepage based memmap. This further let us more than halve the overhead with 1GB pages (40M -> 16M per Tb) In terms of savings, per 1Tb of memory, the struct page cost would go down with compound pagemap: * with 2M pages we lose 4G instead of 16G (0.39% instead of 1.5% of total memory) * with 1G pages we lose 16MB instead of 16G (0.0014% instead of 1.5% of total memory) Along the way I've extended it past 'struct page' overhead *trying* to address a few performance issues we knew about for pmem, specifically on the {pin,get}_user_pages_fast with device-dax vmas which are really slow even of the fast variants. THP is great on -fast variants but all except hugetlbfs perform rather poorly on non-fast gup. Although I deferred the __get_user_pages() improvements (in a follow up series I have stashed as its ortogonal to device-dax as THP suffers from the same syndrome). So to summarize what the series does: Patch 1: Prepare hwpoisoning to work with dax compound pages. Patches 2-4: Have memmap_init_zone_device() initialize its metadata as compound pages. We split the current utility function of prep_compound_page() into head and tail and use those two helpers where appropriate to take advantage of caches being warm after __init_single_page(). Since RFC this also lets us further speed up from 190ms down to 80ms init time. Patches 5-10: Much like Muchun series, we reuse PTE (and PMD) tail page vmemmap areas across a given page size (namely @align was referred by remaining memremap/dax code) and enabling of memremap to initialize the ZONE_DEVICE pages as compound pages or a given @align order. The main difference though, is that contrary to the hugetlbfs series, there's no vmemmap for the area, because we are populating it as opposed to remapping it. IOW no freeing of pages of already initialized vmemmap like the case for hugetlbfs, which simplifies the logic (besides not being arch-specific). After these, there's quite visible region bootstrap of pmem memmap given that we would initialize fewer struct pages depending on the page size with DRAM backed struct pages. altmap sees no difference in bootstrap. NVDIMM namespace bootstrap improves from ~268-358 ms to ~78-100/<1ms on 128G NVDIMMs with 2M and 1G respectivally. Patch 11: Optimize grabbing page refcount changes given that we are working with compound pages i.e. we do 1 increment to the head page for a given set of N subpages compared as opposed to N individual writes. {get,pin}_user_pages_fast() for zone_device with compound pagemap consequently improves considerably with DRAM stored struct pages. It also *greatly* improves pinning with altmap. Results with gup_test: before after (16G get_user_pages_fast 2M page size) ~59 ms -> ~6.1 ms (16G pin_user_pages_fast 2M page size) ~87 ms -> ~6.2 ms (16G get_user_pages_fast altmap 2M page size) ~494 ms -> ~9 ms (16G pin_user_pages_fast altmap 2M page size) ~494 ms -> ~10 ms altmap performance gets specially interesting when pinning a pmem dimm: before after (128G get_user_pages_fast 2M page size) ~492 ms -> ~49 ms (128G pin_user_pages_fast 2M page size) ~493 ms -> ~50 ms (128G get_user_pages_fast altmap 2M page size) ~3.91 ms -> ~70 ms (128G pin_user_pages_fast altmap 2M page size) ~3.97 ms -> ~74 ms The unpinning improvement patches are in mmotm/linux-next so removed from this series. I have deferred the __get_user_pages() patch to outside this series (https://lore.kernel.org/linux-mm/20201208172901.17384-11-joao.m.martins@oracle.com/), as I found an simpler way to address it and that is also applicable to THP. But will submit that as a follow up of this. Patches apply on top of linux-next tag next-20210325 (commit b4f20b70784a). Comments and suggestions very much appreciated! Changelog, RFC -> v1: (New patches 1-3, 5-8 but the diffstat is that different) * Fix hwpoisoning of devmap pages reported by Jane (Patch 1 is new in v1) * Fix/Massage commit messages to be more clear and remove the 'we' occurences (Dan, John, Matthew) * Use pfn_align to be clear it's nr of pages for @align value (John, Dan) * Add two helpers pgmap_align() and pgmap_pfn_align() as accessors of pgmap->align; * Remove the gup_device_compound_huge special path and have the same code work both ways while special casing when devmap page is compound (Jason, John) * Avoid usage of vmemmap_populate_basepages() and introduce a first class loop that doesn't care about passing an altmap for memmap reuse. (Dan) * Completely rework the vmemmap_populate_compound() to avoid the sparse_add_section hack into passing block across sparse_add_section calls. It's a lot easier to follow and more explicit in what it does. * Replace the vmemmap refactoring with adding a @pgmap argument and moving parts of the vmemmap_populate_base_pages(). (Patch 5 and 6 are new as a result) * Add PMD tail page vmemmap area reuse for 1GB pages. (Patch 8 is new) * Improve memmap_init_zone_device() to initialize compound pages when struct pages are cache warm. That lead to a even further speed up further from RFC series from 190ms -> 80-120ms. Patches 2 and 3 are the new ones as a result (Dan) * Remove PGMAP_COMPOUND and use @align as the property to detect whether or not to reuse vmemmap areas (Dan) Thanks, Joao Joao Martins (11): memory-failure: fetch compound_head after pgmap_pfn_valid() mm/page_alloc: split prep_compound_page into head and tail subparts mm/page_alloc: refactor memmap_init_zone_device() page init mm/memremap: add ZONE_DEVICE support for compound pages mm/sparse-vmemmap: add a pgmap argument to section activation mm/sparse-vmemmap: refactor vmemmap_populate_basepages() mm/sparse-vmemmap: populate compound pagemaps mm/sparse-vmemmap: use hugepages for PUD compound pagemaps mm/page_alloc: reuse tail struct pages for compound pagemaps device-dax: compound pagemap support mm/gup: grab head page refcount once for group of subpages drivers/dax/device.c | 58 +++++++-- include/linux/memory_hotplug.h | 5 +- include/linux/memremap.h | 13 ++ include/linux/mm.h | 8 +- mm/gup.c | 52 +++++--- mm/memory-failure.c | 2 + mm/memory_hotplug.c | 3 +- mm/memremap.c | 9 +- mm/page_alloc.c | 126 +++++++++++++------ mm/sparse-vmemmap.c | 221 +++++++++++++++++++++++++++++---- mm/sparse.c | 24 ++-- 11 files changed, 406 insertions(+), 115 deletions(-)