| Message ID | 20210401155211.2093139-2-ckuehl@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix segfault in qemu_rbd_parse_filename | expand |
On 01.04.21 17:52, Connor Kuehl wrote: > The deprecation message changed slightly at some point in the past but > the expected output wasn't updated along with it; causing it to fail. > Fix it, so it passes. > > Signed-off-by: Connor Kuehl <ckuehl@redhat.com> > --- > tests/qemu-iotests/231.out | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Uh, well, you know what, I can’t find any version where there was any other output. Even back in 66e6a735e97450ac50fcaf40f78600c688534cae, where this test was introduced, I get this diff. What’s going on there? Max
On 01.04.21 18:52, Max Reitz wrote: > On 01.04.21 17:52, Connor Kuehl wrote: >> The deprecation message changed slightly at some point in the past but >> the expected output wasn't updated along with it; causing it to fail. >> Fix it, so it passes. >> >> Signed-off-by: Connor Kuehl <ckuehl@redhat.com> >> --- >> tests/qemu-iotests/231.out | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Uh, well, you know what, I can’t find any version where there was any > other output. Even back in 66e6a735e97450ac50fcaf40f78600c688534cae, > where this test was introduced, I get this diff. > > What’s going on there? Okay. So: Jeff’s original patch[1] included the “Future versions may cease to parse...” part. v1 of his subsequent pull request[2] did, too. But v2[3] didn’t. Looks like Markus made a comment on v4 of the patch, and then Jeff fixed up the patch in his branch, but didn’t change the test. In any case it’s clear that the reference output was wrong all along. About the “no monitors specified” part... The only place where I can find “no monitors” is in Jeff’s patches to add this iotest. I have no idea where that orignated from. So: Reviewed-by: Max Reitz <mreitz@redhat.com> [1] https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00282.html [2] https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00307.html [3] https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00592.html
On 4/1/21 12:07 PM, Max Reitz wrote: > On 01.04.21 18:52, Max Reitz wrote: >> On 01.04.21 17:52, Connor Kuehl wrote: >>> The deprecation message changed slightly at some point in the past but >>> the expected output wasn't updated along with it; causing it to fail. >>> Fix it, so it passes. >>> >>> Signed-off-by: Connor Kuehl <ckuehl@redhat.com> >>> --- >>> tests/qemu-iotests/231.out | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> Uh, well, you know what, I can’t find any version where there was any >> other output. Even back in 66e6a735e97450ac50fcaf40f78600c688534cae, >> where this test was introduced, I get this diff. >> >> What’s going on there? > > Okay. So: > > Jeff’s original patch[1] included the “Future versions may cease to > parse...” part. v1 of his subsequent pull request[2] did, too. But > v2[3] didn’t. Looks like Markus made a comment on v4 of the patch, and > then Jeff fixed up the patch in his branch, but didn’t change the test. > In any case it’s clear that the reference output was wrong all along. > > About the “no monitors specified” part... The only place where I can > find “no monitors” is in Jeff’s patches to add this iotest. I have no > idea where that orignated from. > > So: > > Reviewed-by: Max Reitz <mreitz@redhat.com> Thanks! And excellent sleuthing. This accidental conspiracy went much farther beyond the git log than I thought... Connor > > > [1] > https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00282.html > > [2] > https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00307.html > > [3] > https://lists.nongnu.org/archive/html/qemu-block/2018-09/msg00592.html >
diff --git a/tests/qemu-iotests/231.out b/tests/qemu-iotests/231.out index 579ba11c16..747dd221bb 100644 --- a/tests/qemu-iotests/231.out +++ b/tests/qemu-iotests/231.out @@ -1,9 +1,7 @@ QA output created by 231 -qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated. Future versions may cease to parse these options in the future. +qemu-img: warning: RBD options encoded in the filename as keyvalue pairs is deprecated unable to get monitor info from DNS SRV with service name: ceph-mon -no monitors specified to connect to. qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory unable to get monitor info from DNS SRV with service name: ceph-mon -no monitors specified to connect to. qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory *** done
The deprecation message changed slightly at some point in the past but the expected output wasn't updated along with it; causing it to fail. Fix it, so it passes. Signed-off-by: Connor Kuehl <ckuehl@redhat.com> --- tests/qemu-iotests/231.out | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)