[v5,0/5] KVM: x86: dump_vmcs: don't assume GUEST_IA32_EFER, show MSR autoloads/autosaves

Message

David Edmondson March 18, 2021, 12:08 p.m. UTC

v2:
- Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
- Dump the MSR autoload/autosave lists (Paolo).

v3:
- Rebase to master.
- Check only the load controls (Sean).
- Always show the PTPRs from the VMCS if they exist (Jim/Sean).
- Dig EFER out of the MSR autoload list if it's there (Paulo).
- Calculate and show the effective EFER if it is not coming from
  either the VMCS or the MSR autoload list (Sean).

v4:
- Ensure that each changeset builds with just the previous set.

v5:
- Rebase.
- Remove some cruft from changeset comments.
- Add S-by as appropriate.

David Edmondson (5):
  KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
  KVM: x86: dump_vmcs should not conflate EFER and PAT presence in VMCS
  KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT
  KVM: x86: dump_vmcs should show the effective EFER
  KVM: x86: dump_vmcs should include the autoload/autostore MSR lists

 arch/x86/kvm/vmx/vmx.c | 58 +++++++++++++++++++++++++++++-------------
 arch/x86/kvm/vmx/vmx.h |  2 +-
 2 files changed, 42 insertions(+), 18 deletions(-)

Comments

David Edmondson March 29, 2021, 6:23 p.m. UTC | #1

On Thursday, 2021-03-18 at 12:08:36 GMT, David Edmondson wrote:

> v2:
> - Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
> - Dump the MSR autoload/autosave lists (Paolo).
>
> v3:
> - Rebase to master.
> - Check only the load controls (Sean).
> - Always show the PTPRs from the VMCS if they exist (Jim/Sean).
> - Dig EFER out of the MSR autoload list if it's there (Paulo).
> - Calculate and show the effective EFER if it is not coming from
>   either the VMCS or the MSR autoload list (Sean).
>
> v4:
> - Ensure that each changeset builds with just the previous set.
>
> v5:
> - Rebase.
> - Remove some cruft from changeset comments.
> - Add S-by as appropriate.

Any further comments or suggestions?

Thanks.

> David Edmondson (5):
>   KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
>   KVM: x86: dump_vmcs should not conflate EFER and PAT presence in VMCS
>   KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT
>   KVM: x86: dump_vmcs should show the effective EFER
>   KVM: x86: dump_vmcs should include the autoload/autostore MSR lists
>
>  arch/x86/kvm/vmx/vmx.c | 58 +++++++++++++++++++++++++++++-------------
>  arch/x86/kvm/vmx/vmx.h |  2 +-
>  2 files changed, 42 insertions(+), 18 deletions(-)
>
> -- 
> 2.30.2

dme.

Paolo Bonzini April 1, 2021, 12:54 p.m. UTC | #2

On 18/03/21 13:08, David Edmondson wrote:
> v2:
> - Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
> - Dump the MSR autoload/autosave lists (Paolo).
> 
> v3:
> - Rebase to master.
> - Check only the load controls (Sean).
> - Always show the PTPRs from the VMCS if they exist (Jim/Sean).
> - Dig EFER out of the MSR autoload list if it's there (Paulo).
> - Calculate and show the effective EFER if it is not coming from
>    either the VMCS or the MSR autoload list (Sean).
> 
> v4:
> - Ensure that each changeset builds with just the previous set.
> 
> v5:
> - Rebase.
> - Remove some cruft from changeset comments.
> - Add S-by as appropriate.
> 
> David Edmondson (5):
>    KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
>    KVM: x86: dump_vmcs should not conflate EFER and PAT presence in VMCS
>    KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT
>    KVM: x86: dump_vmcs should show the effective EFER
>    KVM: x86: dump_vmcs should include the autoload/autostore MSR lists
> 
>   arch/x86/kvm/vmx/vmx.c | 58 +++++++++++++++++++++++++++++-------------
>   arch/x86/kvm/vmx/vmx.h |  2 +-
>   2 files changed, 42 insertions(+), 18 deletions(-)
> 

Queued, thanks.

Paolo