| Message ID | 20210317022255.2536745-1-fenghua.yu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Miscellaneous fixes for resctrl selftests | expand |
Hi, Shuah, On Wed, Mar 17, 2021 at 02:22:34AM +0000, Fenghua Yu wrote: > This patch set has several miscellaneous fixes to resctrl selftest tool > that are easily visible to user. V1 had fixes to CAT test and CMT test > but they were dropped in V2 because having them here made the patchset > humongous. So, changes to CAT test and CMT test will be posted in another > patchset. > > Change Log: > v6: > - Add Tested-by: Babu Moger <babu.moger@amd.com>. > - Replace "cat" by CAT_STR etc (Babu). > - Capitalize the first letter of printed message (Babu). Any comment on this series? Will you push it into linux-kselftest.git? Thanks. -Fenghua
On 3/26/21 1:45 PM, Fenghua Yu wrote: > Hi, Shuah, > > On Wed, Mar 17, 2021 at 02:22:34AM +0000, Fenghua Yu wrote: >> This patch set has several miscellaneous fixes to resctrl selftest tool >> that are easily visible to user. V1 had fixes to CAT test and CMT test >> but they were dropped in V2 because having them here made the patchset >> humongous. So, changes to CAT test and CMT test will be posted in another >> patchset. >> >> Change Log: >> v6: >> - Add Tested-by: Babu Moger <babu.moger@amd.com>. >> - Replace "cat" by CAT_STR etc (Babu). >> - Capitalize the first letter of printed message (Babu). > > Any comment on this series? Will you push it into linux-kselftest.git? > Yes. Will apply for 5.13-rc1 thanks, -- Shuah
Hi, Shuah, On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote: > On 3/26/21 1:45 PM, Fenghua Yu wrote: > > Hi, Shuah, > > > > On Wed, Mar 17, 2021 at 02:22:34AM +0000, Fenghua Yu wrote: > > > This patch set has several miscellaneous fixes to resctrl selftest tool > > > that are easily visible to user. V1 had fixes to CAT test and CMT test > > > but they were dropped in V2 because having them here made the patchset > > > humongous. So, changes to CAT test and CMT test will be posted in another > > > patchset. > > > > > > Change Log: > > > v6: > > > - Add Tested-by: Babu Moger <babu.moger@amd.com>. > > > - Replace "cat" by CAT_STR etc (Babu). > > > - Capitalize the first letter of printed message (Babu). > > > > Any comment on this series? Will you push it into linux-kselftest.git? > > > Yes. Will apply for 5.13-rc1 Great! Thank you very much for your help! -Fenghua
On 4/2/21 12:18 PM, Fenghua Yu wrote: > Hi, Shuah, > > On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote: >> On 3/26/21 1:45 PM, Fenghua Yu wrote: >>> Hi, Shuah, >>> >>> On Wed, Mar 17, 2021 at 02:22:34AM +0000, Fenghua Yu wrote: >>>> This patch set has several miscellaneous fixes to resctrl selftest tool >>>> that are easily visible to user. V1 had fixes to CAT test and CMT test >>>> but they were dropped in V2 because having them here made the patchset >>>> humongous. So, changes to CAT test and CMT test will be posted in another >>>> patchset. >>>> >>>> Change Log: >>>> v6: >>>> - Add Tested-by: Babu Moger <babu.moger@amd.com>. >>>> - Replace "cat" by CAT_STR etc (Babu). >>>> - Capitalize the first letter of printed message (Babu). >>> >>> Any comment on this series? Will you push it into linux-kselftest.git? >>> >> Yes. Will apply for 5.13-rc1 > > Great! Thank you very much for your help! > Done. Now applied to linux-selftest next. https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/ next Ran sanity test and suggested a change in message for 12/21. Please take a look other such messages and improve them as well and send follow-on patches. thanks, -- Shuah
On Fri, Apr 02, 2021 at 02:04:16PM -0600, Shuah Khan wrote: > On 4/2/21 12:18 PM, Fenghua Yu wrote: > > Hi, Shuah, > > > > On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote: > > > On 3/26/21 1:45 PM, Fenghua Yu wrote: > > > > Hi, Shuah, > > > > > > > > On Wed, Mar 17, 2021 at 02:22:34AM +0000, Fenghua Yu wrote: > > > > > This patch set has several miscellaneous fixes to resctrl selftest tool > > > > > that are easily visible to user. V1 had fixes to CAT test and CMT test > > > > > but they were dropped in V2 because having them here made the patchset > > > > > humongous. So, changes to CAT test and CMT test will be posted in another > > > > > patchset. > > > > > > > > > > Change Log: > > > > > v6: > > > > > - Add Tested-by: Babu Moger <babu.moger@amd.com>. > > > > > - Replace "cat" by CAT_STR etc (Babu). > > > > > - Capitalize the first letter of printed message (Babu). > > > > > > > > Any comment on this series? Will you push it into linux-kselftest.git? > > > > > > > Yes. Will apply for 5.13-rc1 > > > > Great! Thank you very much for your help! > > > > Done. Now applied to linux-selftest next. > > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/ > next > > Ran sanity test and suggested a change in message for 12/21. > > Please take a look other such messages and improve them as well > and send follow-on patches. Sure. Will send a follow-on patch to change the messages. Thanks. -Fenghua
This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having them here made the patchset humongous. So, changes to CAT test and CMT test will be posted in another patchset. Change Log: v6: - Add Tested-by: Babu Moger <babu.moger@amd.com>. - Replace "cat" by CAT_STR etc (Babu). - Capitalize the first letter of printed message (Babu). v5: - Address various comments from Shuah Khan: 1. Move a few fixing patches before cleaning patches. 2. Call kselftest APIs to log test results instead of printf(). 3. Add .gitignore to ignore resctrl_tests. 4. Share show_cache_info() in CAT and CMT tests. 5. Define long_mask, cbm_mask, count_of_bits etc as static variables. v4: - Address various comments from Shuah Khan: 1. Combine a few patches e.g. a couple of fixing typos patches into one and a couple of unmounting patches into one etc. 2. Add config file. 3. Remove "Fixes" tags. 4. Change strcmp() to strncmp(). 5. Move the global variable fixing patch to the patch 1 so that the compilation issue is fixed first. Please note: - I didn't move the patch of renaming CQM to CMT to the end of the series because code and commit messages in a few other patches depend on the new term of "CMT". If move the renaming patch to the end, the previous patches use the old "CQM" term and code which will be changed soon at the end of series and will cause more code and explanations. [v3: https://lkml.org/lkml/2020/10/28/137] v3: Address various comments (commit messages, return value on test failure, print failure info on test failure etc) from Reinette and Tony. [v2: https://lore.kernel.org/linux-kselftest/cover.1589835155.git.sai.praneeth.prakhya@intel.com/] v2: 1. Dropped changes to CAT test and CMT test as they will be posted in a later series. 2. Added several other fixes [v1: https://lore.kernel.org/linux-kselftest/cover.1583657204.git.sai.praneeth.prakhya@intel.com/] Fenghua Yu (19): selftests/resctrl: Enable gcc checks to detect buffer overflows selftests/resctrl: Fix compilation issues for global variables selftests/resctrl: Fix compilation issues for other global variables selftests/resctrl: Clean up resctrl features check selftests/resctrl: Fix missing options "-n" and "-p" selftests/resctrl: Rename CQM test as CMT test selftests/resctrl: Call kselftest APIs to log test results selftests/resctrl: Share show_cache_info() by CAT and CMT tests selftests/resctrl: Add config dependencies selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported selftests/resctrl: Use resctrl/info for feature detection selftests/resctrl: Fix MBA/MBM results reporting format selftests/resctrl: Don't hard code value of "no_of_bits" variable selftests/resctrl: Modularize resctrl test suite main() function selftests/resctrl: Skip the test if requested resctrl feature is not supported selftests/resctrl: Fix unmount resctrl FS selftests/resctrl: Fix incorrect parsing of iMC counters selftests/resctrl: Fix checking for < 0 for unsigned values selftests/resctrl: Create .gitignore to include resctrl_tests Reinette Chatre (2): selftests/resctrl: Ensure sibling CPU is not same as original CPU selftests/resctrl: Fix a printed message tools/testing/selftests/resctrl/.gitignore | 2 + tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/README | 4 +- tools/testing/selftests/resctrl/cache.c | 52 +++++- tools/testing/selftests/resctrl/cat_test.c | 57 ++---- .../resctrl/{cqm_test.c => cmt_test.c} | 75 +++----- tools/testing/selftests/resctrl/config | 2 + tools/testing/selftests/resctrl/fill_buf.c | 4 +- tools/testing/selftests/resctrl/mba_test.c | 43 ++--- tools/testing/selftests/resctrl/mbm_test.c | 42 ++--- tools/testing/selftests/resctrl/resctrl.h | 29 +++- .../testing/selftests/resctrl/resctrl_tests.c | 163 ++++++++++++------ tools/testing/selftests/resctrl/resctrl_val.c | 95 ++++++---- tools/testing/selftests/resctrl/resctrlfs.c | 134 ++++++++------ 14 files changed, 408 insertions(+), 296 deletions(-) create mode 100644 tools/testing/selftests/resctrl/.gitignore rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (56%) create mode 100644 tools/testing/selftests/resctrl/config