| Message ID | 20210407223347.28669-1-sonnysasaka@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | [BlueZ] input/hog-lib: do not silently ignore missing connection in read_char() | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=462829 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - PASS ############################## Test: CheckBuild: Setup ELL - PASS ############################## Test: CheckBuild: Setup - PASS ############################## Test: CheckBuild - PASS ############################## Test: MakeCheck - PASS ############################## Test: CheckBuild w/external ell - PASS --- Regards, Linux Bluetooth
diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c index 6ac14e401..6605538cf 100644 --- a/profiles/input/hog-lib.c +++ b/profiles/input/hog-lib.c @@ -181,10 +181,6 @@ static void read_char(struct bt_hog *hog, GAttrib *attrib, uint16_t handle, struct gatt_request *req; unsigned int id; - /* Ignore if not connected */ - if (!attrib) - return; - req = create_request(hog, user_data); if (!req) return;
From: Dmitry Torokhov <dtor@chromium.org> Currently we silently ignore missing connection (attrib) in read_char(), but not in the other GATT interfaces (such as write_char, discover_desc, etc). The code should avoid calling read_char() when there is no active connection instead, and logging errors will help us trace the offenders. --- profiles/input/hog-lib.c | 4 ---- 1 file changed, 4 deletions(-)