| Message ID | 20210408093215.24023-1-jinpu.wang@ionos.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [v3] RDMA/ipoib: print a message if only child interface is UP | expand |
On Thu, Apr 08, 2021 at 11:32:15AM +0200, Jack Wang wrote: > When "enhanced IPoIB" enabled for CX-5 devices, it requires > the parent device to be UP, otherwise the child devices won't > work. > > This add a debug message to give admin a hint, if only child interface > is UP, but parent interface is not. > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index e16b40c09f82..df6329abac1d 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -164,8 +164,13 @@ int ipoib_open(struct net_device *dev) > dev_change_flags(cpriv->dev, flags | IFF_UP, NULL); > } > up_read(&priv->vlan_rwsem); > - } > + } else if (priv->parent) { > + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent); > > + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags)) > + ipoib_dbg(priv, "parent device %s is not up, so child device may be not functioning.\n", > + ppriv->dev->name); I personally would use stronger language than that. Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Thanks > + } > netif_start_queue(dev); > > return 0; > -- > 2.25.1 >
On Thu, Apr 8, 2021 at 11:48 AM Leon Romanovsky <leon@kernel.org> wrote: > > On Thu, Apr 08, 2021 at 11:32:15AM +0200, Jack Wang wrote: > > When "enhanced IPoIB" enabled for CX-5 devices, it requires > > the parent device to be UP, otherwise the child devices won't > > work. > > > > This add a debug message to give admin a hint, if only child interface > > is UP, but parent interface is not. > > > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > > --- > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > > index e16b40c09f82..df6329abac1d 100644 > > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > > @@ -164,8 +164,13 @@ int ipoib_open(struct net_device *dev) > > dev_change_flags(cpriv->dev, flags | IFF_UP, NULL); > > } > > up_read(&priv->vlan_rwsem); > > - } > > + } else if (priv->parent) { > > + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent); > > > > + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags)) > > + ipoib_dbg(priv, "parent device %s is not up, so child device may be not functioning.\n", > > + ppriv->dev->name); > > > I personally would use stronger language than that. As there is configuration like on old CX-2/CX-3 HCA, it works fine, so I use such language. > > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > Thanks Thanks for the review! > > > + } > > netif_start_queue(dev); > > > > return 0; > > -- > > 2.25.1 > >
On Thu, Apr 08, 2021 at 11:32:15AM +0200, Jack Wang wrote: > When "enhanced IPoIB" enabled for CX-5 devices, it requires > the parent device to be UP, otherwise the child devices won't > work. > > This add a debug message to give admin a hint, if only child interface > is UP, but parent interface is not. > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index e16b40c09f82..df6329abac1d 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -164,8 +164,13 @@ int ipoib_open(struct net_device *dev) dev_change_flags(cpriv->dev, flags | IFF_UP, NULL); } up_read(&priv->vlan_rwsem); - } + } else if (priv->parent) { + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent); + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags)) + ipoib_dbg(priv, "parent device %s is not up, so child device may be not functioning.\n", + ppriv->dev->name); + } netif_start_queue(dev); return 0;
When "enhanced IPoIB" enabled for CX-5 devices, it requires the parent device to be UP, otherwise the child devices won't work. This add a debug message to give admin a hint, if only child interface is UP, but parent interface is not. Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)