[v9,0/4] Multiple BSSID support

Message

Aloka Dixit March 10, 2021, 6:26 p.m. UTC

This patchset adds support for multiple BSSID and
enhanced multi-BSSID advertisements.

This version modifies only nl80211 patch (1/4) which describes
the difference.

John Crispin (4):
  nl80211: add basic multiple bssid support
  mac80211: add multiple bssid support to interface handling
  mac80211: add multiple bssid/EMA support to beacon handling
  mac80211: CSA on non-transmitting interfaces

 include/net/cfg80211.h       |  47 ++++++
 include/net/mac80211.h       | 116 ++++++++++++++-
 include/uapi/linux/nl80211.h |  84 +++++++++++
 net/mac80211/cfg.c           | 178 ++++++++++++++++++++--
 net/mac80211/debugfs.c       |   1 +
 net/mac80211/ieee80211_i.h   |   2 +
 net/mac80211/iface.c         |   6 +
 net/mac80211/tx.c            | 189 ++++++++++++++++++++---
 net/wireless/nl80211.c       | 280 ++++++++++++++++++++++++++++++-----
 9 files changed, 830 insertions(+), 73 deletions(-)


base-commit: 38b5133ad607ecdcc8d24906d1ac9cc8df41acd5

Comments

Johannes Berg April 8, 2021, 11:53 a.m. UTC | #1

On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
> This patchset adds support for multiple BSSID and
> enhanced multi-BSSID advertisements.

All of this, in particular the subjects, should really mention that it's
for AP side.

Does it apply also for mesh, btw?

johannes

Johannes Berg April 8, 2021, 12:17 p.m. UTC | #2

On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
> This patchset adds support for multiple BSSID and
> enhanced multi-BSSID advertisements.
> 
> This version modifies only nl80211 patch (1/4) which describes
> the difference.
> 
> John Crispin (4):
>   nl80211: add basic multiple bssid support
>   mac80211: add multiple bssid support to interface handling
>   mac80211: add multiple bssid/EMA support to beacon handling
>   mac80211: CSA on non-transmitting interfaces

Also, can we have hwsim support for proper testing? Seems with all the
logic in mac80211 to give you the right beacons etc. that should be
really simple?

johannes

Aloka Dixit April 9, 2021, 6:05 p.m. UTC | #3

On 2021-04-08 04:53, Johannes Berg wrote:
> On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
>> This patchset adds support for multiple BSSID and
>> enhanced multi-BSSID advertisements.
> 
> All of this, in particular the subjects, should really mention that 
> it's
> for AP side.
> 
> Does it apply also for mesh, btw?
> 
> johannes

No, this patchset is only for AP mode.
Will mention it in the titles/commit_logs/comments.
Thanks.

Aloka Dixit April 9, 2021, 6:31 p.m. UTC | #4

On 2021-04-08 05:17, Johannes Berg wrote:
> On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
>> This patchset adds support for multiple BSSID and
>> enhanced multi-BSSID advertisements.
>> 
>> This version modifies only nl80211 patch (1/4) which describes
>> the difference.
>> 
>> John Crispin (4):
>>   nl80211: add basic multiple bssid support
>>   mac80211: add multiple bssid support to interface handling
>>   mac80211: add multiple bssid/EMA support to beacon handling
>>   mac80211: CSA on non-transmitting interfaces
> 
> Also, can we have hwsim support for proper testing? Seems with all the
> logic in mac80211 to give you the right beacons etc. that should be
> really simple?
> 
> johannes

Sure, will add hwsim tests.

BTW, do you see value in replacing all occurrences
of *_multiple_bssid_* with *_mbssid_* (also in new
nl80211 attributes).
Most lines needed to be split because of 80 character
boundary, so this replacement will make that code
look cleaner. I have avoided it till now to reduce
number of changes between versions.
Thanks.

Johannes Berg April 9, 2021, 7:28 p.m. UTC | #5

On Fri, 2021-04-09 at 11:31 -0700, Aloka Dixit wrote:
> 
> BTW, do you see value in replacing all occurrences
> of *_multiple_bssid_* with *_mbssid_* (also in new
> nl80211 attributes).
> Most lines needed to be split because of 80 character
> boundary, so this replacement will make that code
> look cleaner. I have avoided it till now to reduce
> number of changes between versions.

Might be nicer, but I can live with the longer identifiers too. I don't
really mind if you do it between versions though, so feel free.

johannes