| Message ID | 20210416105632.8771-1-james.clark@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | perf cs-etm: Set time on synthesised samples to preserve ordering | expand |
Hi James, On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: > Changes since v1: > * Improved variable name from etm_timestamp -> cs_timestamp > * Fixed ordering of Signed-off-by > You forgot to add the RB and AB you received. Since Arnaldo is responsible for the perf tools subsystem, please send another revision. Thanks, Mathieu > James Clark (2): > perf cs-etm: Refactor timestamp variable names > perf cs-etm: Set time on synthesised samples to preserve ordering > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- > tools/perf/util/cs-etm.c | 52 ++++++++++--------- > tools/perf/util/cs-etm.h | 4 +- > 3 files changed, 39 insertions(+), 35 deletions(-) > > -- > 2.28.0 >
Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu: > Hi James, > > On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: > > Changes since v1: > > * Improved variable name from etm_timestamp -> cs_timestamp > > * Fixed ordering of Signed-off-by > > > > You forgot to add the RB and AB you received. Since Arnaldo is responsible for > the perf tools subsystem, please send another revision. Yep, please collect Reported-by and Acked-by as you go sending new versions of a patchset, the last one I don't have a problem collecting myself, but if you have to resend, please collect the feedback tags. - Arnaldo > Thanks, > Mathieu > > > James Clark (2): > > perf cs-etm: Refactor timestamp variable names > > perf cs-etm: Set time on synthesised samples to preserve ordering > > > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- > > tools/perf/util/cs-etm.c | 52 ++++++++++--------- > > tools/perf/util/cs-etm.h | 4 +- > > 3 files changed, 39 insertions(+), 35 deletions(-) > > > > -- > > 2.28.0 > >
On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu: >> Hi James, >> >> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: >>> Changes since v1: >>> * Improved variable name from etm_timestamp -> cs_timestamp >>> * Fixed ordering of Signed-off-by >>> >> >> You forgot to add the RB and AB you received. Since Arnaldo is responsible for >> the perf tools subsystem, please send another revision. > > > > Yep, please collect Reported-by and Acked-by as you go sending new > versions of a patchset, the last one I don't have a problem collecting > myself, but if you have to resend, please collect the feedback tags. > > - Arnaldo > Ok thanks, I will keep that in mind for the future. I wasn't sure if they still applied or not as it was a new version. Thanks James >> Thanks, >> Mathieu >> >>> James Clark (2): >>> perf cs-etm: Refactor timestamp variable names >>> perf cs-etm: Set time on synthesised samples to preserve ordering >>> >>> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- >>> tools/perf/util/cs-etm.c | 52 ++++++++++--------- >>> tools/perf/util/cs-etm.h | 4 +- >>> 3 files changed, 39 insertions(+), 35 deletions(-) >>> >>> -- >>> 2.28.0 >>> >