| Message ID | 20210407132543.23652-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 361e5fc7420ab56e4a940b8a500207a91830cd32 |
| Headers | show |
| Series | [v2,-next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize() | expand |
On Wed, Apr 07, 2021 at 09:25:43PM +0800, YueHaibing wrote: > > commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part") > left behind this, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks for the cleanup. Regards, Ludovic > --- > v2: Fix commit log > --- > drivers/dma/at_xdmac.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index fe45ad5d06c4..64a52bf4d737 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan) > return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status); > } > > -static inline int at_xdmac_csize(u32 maxburst) > -{ > - int csize; > - > - csize = ffs(maxburst) - 1; > - if (csize > 4) > - csize = -EINVAL; > - > - return csize; > -}; > - > static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg) > { > return cfg & AT_XDMAC_CC_TYPE_PER_TRAN; > -- > 2.17.1 >
On 07-04-21, 21:25, YueHaibing wrote: > commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part") > left behind this, so can remove it. Applied, thanks
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index fe45ad5d06c4..64a52bf4d737 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan) return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status); } -static inline int at_xdmac_csize(u32 maxburst) -{ - int csize; - - csize = ffs(maxburst) - 1; - if (csize > 4) - csize = -EINVAL; - - return csize; -}; - static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg) { return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part") left behind this, so can remove it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- v2: Fix commit log --- drivers/dma/at_xdmac.c | 11 ----------- 1 file changed, 11 deletions(-)