| Message ID | 20210420113818.378478-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 95dbac94da7f9cff9a056fcf9c3a1679aa5ac337 |
| Headers | show |
| Series | usb: storage: datafab: remove redundant assignment of variable result | expand |
On Tue, Apr 20, 2021 at 12:38:18PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable result is being assigned with a value that is > never read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Acked-by: Alan Stern <stern@rowland.harvard.edu> > drivers/usb/storage/datafab.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c > index 588818483f4b..bcc4a2fad863 100644 > --- a/drivers/usb/storage/datafab.c > +++ b/drivers/usb/storage/datafab.c > @@ -294,7 +294,6 @@ static int datafab_write_data(struct us_data *us, > if (reply[0] != 0x50 && reply[1] != 0) { > usb_stor_dbg(us, "Gah! write return code: %02x %02x\n", > reply[0], reply[1]); > - result = USB_STOR_TRANSPORT_ERROR; > goto leave; > } > > -- > 2.30.2 >
diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c index 588818483f4b..bcc4a2fad863 100644 --- a/drivers/usb/storage/datafab.c +++ b/drivers/usb/storage/datafab.c @@ -294,7 +294,6 @@ static int datafab_write_data(struct us_data *us, if (reply[0] != 0x50 && reply[1] != 0) { usb_stor_dbg(us, "Gah! write return code: %02x %02x\n", reply[0], reply[1]); - result = USB_STOR_TRANSPORT_ERROR; goto leave; }