| Message ID | 1618925829-90071-2-git-send-email-guoren@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] nds32: Cleanup deprecated function strlen_user | expand |
On Tue, Apr 20, 2021 at 3:37 PM <guoren@kernel.org> wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > $ grep strlen_user * -r > arch/csky/include/asm/uaccess.h:#define strlen_user(str) strnlen_user(str, 32767) > arch/csky/lib/usercopy.c: * strlen_user: - Get the size of a string in user space. > arch/ia64/lib/strlen.S: // Please note that in the case of strlen() as opposed to strlen_user() > arch/mips/lib/strnlen_user.S: * make strlen_user and strnlen_user access the first few KSEG0 > arch/nds32/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user * str); > arch/nios2/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user *str); > arch/riscv/include/asm/uaccess.h:extern long __must_check strlen_user(const char __user *str); > kernel/trace/trace_probe_tmpl.h:static nokprobe_inline int fetch_store_strlen_user(unsigned long addr); > kernel/trace/trace_probe_tmpl.h: ret += fetch_store_strlen_user(val + code->offset); > kernel/trace/trace_uprobe.c:fetch_store_strlen_user(unsigned long addr) > kernel/trace/trace_kprobe.c:fetch_store_strlen_user(unsigned long addr) > kernel/trace/trace_kprobe.c: return fetch_store_strlen_user(addr); I would suggest using "grep strlen_user * -rw", to let the whole-word match filter out the irrelevant ones for the changelog. > See grep result, nobody uses it. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Cc: Arnd Bergmann <arnd@arndb.de> All three patches Reviewed-by: Arnd Bergmann <arnd@arndb.de> Do you want me to pick them up in the asm-generic tree?
On Tue, Apr 20, 2021 at 04:32:33PM +0200, Arnd Bergmann wrote: > On Tue, Apr 20, 2021 at 3:37 PM <guoren@kernel.org> wrote: > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > $ grep strlen_user * -r > > arch/csky/include/asm/uaccess.h:#define strlen_user(str) strnlen_user(str, 32767) > > arch/csky/lib/usercopy.c: * strlen_user: - Get the size of a string in user space. > > arch/ia64/lib/strlen.S: // Please note that in the case of strlen() as opposed to strlen_user() > > arch/mips/lib/strnlen_user.S: * make strlen_user and strnlen_user access the first few KSEG0 > > arch/nds32/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user * str); > > arch/nios2/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user *str); > > arch/riscv/include/asm/uaccess.h:extern long __must_check strlen_user(const char __user *str); > > kernel/trace/trace_probe_tmpl.h:static nokprobe_inline int fetch_store_strlen_user(unsigned long addr); > > kernel/trace/trace_probe_tmpl.h: ret += fetch_store_strlen_user(val + code->offset); > > kernel/trace/trace_uprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c: return fetch_store_strlen_user(addr); > > I would suggest using "grep strlen_user * -rw", to let the whole-word match > filter out the irrelevant ones for the changelog. > > > See grep result, nobody uses it. > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > All three patches > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Do you want me to pick them up in the asm-generic tree? Might make sense to check -next from time to time... See a0d8d552783b "whack-a-mole: kill strlen_user() (again)" in there
Thx Arnd, On Tue, Apr 20, 2021 at 10:32 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Tue, Apr 20, 2021 at 3:37 PM <guoren@kernel.org> wrote: > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > $ grep strlen_user * -r > > arch/csky/include/asm/uaccess.h:#define strlen_user(str) strnlen_user(str, 32767) > > arch/csky/lib/usercopy.c: * strlen_user: - Get the size of a string in user space. > > arch/ia64/lib/strlen.S: // Please note that in the case of strlen() as opposed to strlen_user() > > arch/mips/lib/strnlen_user.S: * make strlen_user and strnlen_user access the first few KSEG0 > > arch/nds32/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user * str); > > arch/nios2/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user *str); > > arch/riscv/include/asm/uaccess.h:extern long __must_check strlen_user(const char __user *str); > > kernel/trace/trace_probe_tmpl.h:static nokprobe_inline int fetch_store_strlen_user(unsigned long addr); > > kernel/trace/trace_probe_tmpl.h: ret += fetch_store_strlen_user(val + code->offset); > > kernel/trace/trace_uprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c: return fetch_store_strlen_user(addr); > > I would suggest using "grep strlen_user * -rw", to let the whole-word match > filter out the irrelevant ones for the changelog. > > > See grep result, nobody uses it. > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > All three patches > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Do you want me to pick them up in the asm-generic tree? Yes, please take them.
diff --git a/arch/nios2/include/asm/uaccess.h b/arch/nios2/include/asm/uaccess.h index a741abb..ba9340e 100644 --- a/arch/nios2/include/asm/uaccess.h +++ b/arch/nios2/include/asm/uaccess.h @@ -83,7 +83,6 @@ raw_copy_to_user(void __user *to, const void *from, unsigned long n); extern long strncpy_from_user(char *__to, const char __user *__from, long __len); -extern __must_check long strlen_user(const char __user *str); extern __must_check long strnlen_user(const char __user *s, long n); /* Optimized macros */