| Message ID | 20210305094937.GA141307@embeddedor (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,next] nfp: Fix fall-through warnings for Clang | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 5 maintainers not CCed: xiyou.wangcong@gmail.com clang-built-linux@googlegroups.com ap420073@gmail.com ndesaulniers@google.com nathan@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks Gustavo, this looks good to me. Acked-by: Simon Horman <simon.horman@netronome.com> > --- > drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > index b3cabc274121..3b8e675087de 100644 > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) > case NFP_PORT_PF_PORT: > case NFP_PORT_VF_PORT: > nfp_repr_vnic_get_stats64(repr->port, stats); > + break; > default: > break; > } > -- > 2.27.0 >
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 06:19, Simon Horman wrote: > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a break statement instead of letting the code fall >> through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > Thanks Gustavo, > > this looks good to me. > > Acked-by: Simon Horman <simon.horman@netronome.com> > >> --- >> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >> index b3cabc274121..3b8e675087de 100644 >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) >> case NFP_PORT_PF_PORT: >> case NFP_PORT_VF_PORT: >> nfp_repr_vnic_get_stats64(repr->port, stats); >> + break; >> default: >> break; >> } >> -- >> 2.27.0 >>
On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote: > On 3/5/21 06:19, Simon Horman wrote: > > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > >> by explicitly adding a break statement instead of letting the code fall > >> through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > > Thanks Gustavo, > > > > this looks good to me. > > > > Acked-by: Simon Horman <simon.horman@netronome.com> > > Hi all, > > Friendly ping: who can take this, please? Hi Jakub, Hi David, I'm happy to repost this patch if it would help with your processes. > >> --- > >> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> index b3cabc274121..3b8e675087de 100644 > >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) > >> case NFP_PORT_PF_PORT: > >> case NFP_PORT_VF_PORT: > >> nfp_repr_vnic_get_stats64(repr->port, stats); > >> + break; > >> default: > >> break; > >> } > >> -- > >> 2.27.0 > >>
Hi all, I'm taking this in my -next[1] branch for v5.14. Thanks -- Gustavo [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp On 4/21/21 04:39, Simon Horman wrote: > On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote: >> On 3/5/21 06:19, Simon Horman wrote: >>> On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: >>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >>>> by explicitly adding a break statement instead of letting the code fall >>>> through to the next case. >>>> >>>> Link: https://github.com/KSPP/linux/issues/115 >>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>> >>> Thanks Gustavo, >>> >>> this looks good to me. >>> >>> Acked-by: Simon Horman <simon.horman@netronome.com> >> >> Hi all, >> >> Friendly ping: who can take this, please? > > Hi Jakub, Hi David, > > I'm happy to repost this patch if it would help with your processes. > >>>> --- >>>> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >>>> index b3cabc274121..3b8e675087de 100644 >>>> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >>>> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c >>>> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) >>>> case NFP_PORT_PF_PORT: >>>> case NFP_PORT_VF_PORT: >>>> nfp_repr_vnic_get_stats64(repr->port, stats); >>>> + break; >>>> default: >>>> break; >>>> } >>>> -- >>>> 2.27.0 >>>>
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c index b3cabc274121..3b8e675087de 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) case NFP_PORT_PF_PORT: case NFP_PORT_VF_PORT: nfp_repr_vnic_get_stats64(repr->port, stats); + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + 1 file changed, 1 insertion(+)