diff mbox series

ACPI: APEI: remove redundant assignment to variable rc

Message ID 20210415143758.1962567-1-colin.king@canonical.com (mailing list archive)
State Mainlined, archived
Headers show
Series ACPI: APEI: remove redundant assignment to variable rc | expand

Commit Message

Colin King April 15, 2021, 2:37 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable rc is being assigned a value that is never read,
the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/acpi/apei/einj.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Rafael J. Wysocki April 21, 2021, 4:52 p.m. UTC | #1 
On Thu, Apr 15, 2021 at 4:38 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable rc is being assigned a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/acpi/apei/einj.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index 133156759551..328e8aeece6c 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -725,7 +725,6 @@ static int __init einj_init(void)
>                 goto err_release;
>         }
>
> -       rc = -ENOMEM;
>         einj_param = einj_get_parameter_address();
>         if ((param_extension || acpi5) && einj_param) {
>                 debugfs_create_x32("flags", S_IRUSR | S_IWUSR, einj_debug_dir,
> --

Applied as 5.13 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 133156759551..328e8aeece6c 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -725,7 +725,6 @@  static int __init einj_init(void)
 		goto err_release;
 	}
 
-	rc = -ENOMEM;
 	einj_param = einj_get_parameter_address();
 	if ((param_extension || acpi5) && einj_param) {
 		debugfs_create_x32("flags", S_IRUSR | S_IWUSR, einj_debug_dir,