| Message ID | 20210415050347.253831-1-inga.stotland@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [BlueZ] shared/timeout-ell: Fix timeout_add() implementation | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=467449 ---Test result--- Test Summary: CheckPatch PASS 0.36 seconds GitLint PASS 0.11 seconds Prep - Setup ELL PASS 45.10 seconds Build - Prep PASS 0.13 seconds Build - Configure PASS 7.92 seconds Build - Make PASS 193.52 seconds Make Check PASS 9.37 seconds Make Dist PASS 11.56 seconds Make Dist - Configure PASS 5.12 seconds Make Dist - Make PASS 84.81 seconds Build w/ext ELL - Configure PASS 8.80 seconds Build w/ext ELL - Make PASS 197.07 seconds Details ############################## Test: CheckPatch - PASS Desc: Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS Desc: Run gitlint with rule in .gitlint ############################## Test: Prep - Setup ELL - PASS Desc: Clone, build, and install ELL ############################## Test: Build - Prep - PASS Desc: Prepare environment for build ############################## Test: Build - Configure - PASS Desc: Configure the BlueZ source tree ############################## Test: Build - Make - PASS Desc: Build the BlueZ source tree ############################## Test: Make Check - PASS Desc: Run 'make check' ############################## Test: Make Dist - PASS Desc: Run 'make dist' and build the distribution tarball ############################## Test: Make Dist - Configure - PASS Desc: Configure the source from distribution tarball ############################## Test: Make Dist - Make - PASS Desc: Build the source from distribution tarball ############################## Test: Build w/ext ELL - Configure - PASS Desc: Configure BlueZ source with '--enable-external-ell' configuration ############################## Test: Build w/ext ELL - Make - PASS Desc: Build BlueZ source with '--enable-external-ell' configuration --- Regards, Linux Bluetooth
Applied, Thanks On Wed, 2021-04-14 at 22:03 -0700, Inga Stotland wrote: > Since timeout_add() expects the timeout in milliseconds, the correct > ELL primitive to call is l_timeout_create_ms() > --- > src/shared/timeout-ell.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/shared/timeout-ell.c b/src/shared/timeout-ell.c > index 6416d8590..026286926 100644 > --- a/src/shared/timeout-ell.c > +++ b/src/shared/timeout-ell.c > @@ -68,7 +68,7 @@ unsigned int timeout_add(unsigned int timeout, timeout_func_t func, > data->timeout = timeout; > > while (id == 0 && tries < 3) { > - to = l_timeout_create(timeout, timeout_callback, > + to = l_timeout_create_ms(timeout, timeout_callback, > data, timeout_destroy); > if (!to) > break;
diff --git a/src/shared/timeout-ell.c b/src/shared/timeout-ell.c index 6416d8590..026286926 100644 --- a/src/shared/timeout-ell.c +++ b/src/shared/timeout-ell.c @@ -68,7 +68,7 @@ unsigned int timeout_add(unsigned int timeout, timeout_func_t func, data->timeout = timeout; while (id == 0 && tries < 3) { - to = l_timeout_create(timeout, timeout_callback, + to = l_timeout_create_ms(timeout, timeout_callback, data, timeout_destroy); if (!to) break;