| Message ID | 1619213997-5475-1-git-send-email-jrdr.linux@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdgpu: Added missing prototype | expand |
Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder: > Kernel test robot throws below warning -> > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning: >>> no previous prototype for 'kgd_arcturus_hqd_sdma_load' >>> [-Wmissing-prototypes] > 125 | int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void > *mqd, > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:227:6: warning: >>> no previous prototype for 'kgd_arcturus_hqd_sdma_is_occupied' >>> [-Wmissing-prototypes] > 227 | bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, > void *mqd) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning: >>> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy' >>> [-Wmissing-prototypes] > 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void > *mqd, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Added prototype for these functions. The prototypes are already defined in amdgpu_amdkfd_arcturus.h. I think we just need to add a #include in amdgpu_amdkfd_arcturus.c. Regards, Felix > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index dc3a692..8fff0e7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -316,6 +316,11 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev, > enum amd_ip_block_type block_type); > bool amdgpu_device_ip_is_idle(struct amdgpu_device *adev, > enum amd_ip_block_type block_type); > +int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void *mqd, > + uint32_t __user *wptr, struct mm_struct *mm); > +bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, void *mqd); > +int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd, > + unsigned int utimeout); > > #define AMDGPU_MAX_IP_NUM 16 >
On Sat, Apr 24, 2021 at 5:03 AM Felix Kuehling <felix.kuehling@amd.com> wrote: > > Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder: > > Kernel test robot throws below warning -> > > > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning: > >>> no previous prototype for 'kgd_arcturus_hqd_sdma_load' > >>> [-Wmissing-prototypes] > > 125 | int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void > > *mqd, > > > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:227:6: warning: > >>> no previous prototype for 'kgd_arcturus_hqd_sdma_is_occupied' > >>> [-Wmissing-prototypes] > > 227 | bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, > > void *mqd) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning: > >>> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy' > >>> [-Wmissing-prototypes] > > 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void > > *mqd, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Added prototype for these functions. > The prototypes are already defined in amdgpu_amdkfd_arcturus.h. I think > we just need to add a #include in amdgpu_amdkfd_arcturus.c. > Right. I missed that file. Will send v2. > Regards, > Felix > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > index dc3a692..8fff0e7 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > @@ -316,6 +316,11 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev, > > enum amd_ip_block_type block_type); > > bool amdgpu_device_ip_is_idle(struct amdgpu_device *adev, > > enum amd_ip_block_type block_type); > > +int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void *mqd, > > + uint32_t __user *wptr, struct mm_struct *mm); > > +bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, void *mqd); > > +int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd, > > + unsigned int utimeout); > > > > #define AMDGPU_MAX_IP_NUM 16 > >
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index dc3a692..8fff0e7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -316,6 +316,11 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev, enum amd_ip_block_type block_type); bool amdgpu_device_ip_is_idle(struct amdgpu_device *adev, enum amd_ip_block_type block_type); +int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void *mqd, + uint32_t __user *wptr, struct mm_struct *mm); +bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, void *mqd); +int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd, + unsigned int utimeout); #define AMDGPU_MAX_IP_NUM 16