| Message ID | 20210319051627.814-1-cnsztl@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v6,1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S | expand |
Hi, Am Freitag, 19. März 2021, 06:16:26 CET schrieb Tianling Shen: > Add devicetree binding documentation for the FriendlyARM NanoPi R4S. > > Changes in v6: > - Fixed format of LED nodes > > Changes in v5: > - Dropped the empty PCIe node > - Dropped useless `/delete-property/` > - Renamed LED nodes > > Changes in v4: > - Correctly dropped `display-subsystem` node > - Dropped meaningless `pwm-fan` node > - Dropped wrong `sdmmc` node > - Disabled `i2c4` and `uart0` as they don't exist in the design > - Format fixes > > Changes in v3: > - Dropped non-existent node `display_subsystem` > > Changes in v2: > - Disable display for NanoPi R4S (reference commit: 74532de460ec) > - Light "sys" LED on NanoPi R4S (reference commit: 833821eeab91) > > Signed-off-by: Tianling Shen <cnsztl@gmail.com> In v4 you received a Acked-by: Rob Herring <robh@kernel.org> Please pick these up and carry them over into new versions of your patchset. Otherwise Rob would needlessly review things multiple times. Heiko > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index c3036f95c7bc..4a6f772c1043 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -134,6 +134,7 @@ properties: > - friendlyarm,nanopi-m4 > - friendlyarm,nanopi-m4b > - friendlyarm,nanopi-neo4 > + - friendlyarm,nanopi-r4s > - const: rockchip,rk3399 > > - description: GeekBuying GeekBox >
On Fri, 19 Mar 2021 13:16:26 +0800, Tianling Shen wrote: > Add devicetree binding documentation for the FriendlyARM NanoPi R4S. > > Changes in v6: > - Fixed format of LED nodes > > Changes in v5: > - Dropped the empty PCIe node > - Dropped useless `/delete-property/` > - Renamed LED nodes > > [...] Applied, thanks! [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 Best regards,
Hi! > > Changes in v6: > > - Fixed format of LED nodes > > > > Changes in v5: > > - Dropped the empty PCIe node > > - Dropped useless `/delete-property/` > > - Renamed LED nodes > > > > [...] > > Applied, thanks! > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 Sorry for late review, but: + label = "red:sys"; This should be red:power based on the discussion in earlier threads. Thanks, Pavel
Hi Pavel, On Mon, Apr 26, 2021 at 5:33 AM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > > Changes in v6: > > > - Fixed format of LED nodes > > > > > > Changes in v5: > > > - Dropped the empty PCIe node > > > - Dropped useless `/delete-property/` > > > - Renamed LED nodes > > > > > > [...] > > > > Applied, thanks! > > > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S > > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 > > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S > > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 > > Sorry for late review, but: > > > + label = "red:sys"; > > This should be red:power based on the discussion in earlier threads. However based on the introduction from FriendlyELEC[1], this is not the "power" lamp... "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)" 1. https://wiki.friendlyarm.com/wiki/index.php/NanoPi_R4S#Hardware_Spec Thanks, Tianling. > > Thanks, > Pavel > -- > http://www.livejournal.com/~pavelmachek
Hi! > > > > - Fixed format of LED nodes > > > > > > > > Changes in v5: > > > > - Dropped the empty PCIe node > > > > - Dropped useless `/delete-property/` > > > > - Renamed LED nodes > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S > > > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 > > > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S > > > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 > > > > Sorry for late review, but: > > > > > > + label = "red:sys"; > > > > This should be red:power based on the discussion in earlier threads. > > However based on the introduction from FriendlyELEC[1], this is not > the "power" lamp... > "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)" It is always on, and "sys" is not a valid function. I'd suggest labeling it as "red:power". Feel free to make other suggestion but lets keep existing functions. Pavel
Hi, On Mon, Apr 26, 2021 at 7:03 PM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > > > - Fixed format of LED nodes > > > > > > > > > > Changes in v5: > > > > > - Dropped the empty PCIe node > > > > > - Dropped useless `/delete-property/` > > > > > - Renamed LED nodes > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S > > > > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 > > > > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S > > > > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 > > > > > > Sorry for late review, but: > > > > > > > > > + label = "red:sys"; > > > > > > This should be red:power based on the discussion in earlier threads. > > > > However based on the introduction from FriendlyELEC[1], this is not > > the "power" lamp... > > "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)" > > It is always on, and "sys" is not a valid function. > > I'd suggest labeling it as "red:power". Feel free to make other > suggestion but lets keep existing functions. I see, thank you very much! I'll submit a patch later. Thanks, Tianling. > Pavel > -- > http://www.livejournal.com/~pavelmachek
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index c3036f95c7bc..4a6f772c1043 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -134,6 +134,7 @@ properties: - friendlyarm,nanopi-m4 - friendlyarm,nanopi-m4b - friendlyarm,nanopi-neo4 + - friendlyarm,nanopi-r4s - const: rockchip,rk3399 - description: GeekBuying GeekBox
Add devicetree binding documentation for the FriendlyARM NanoPi R4S. Changes in v6: - Fixed format of LED nodes Changes in v5: - Dropped the empty PCIe node - Dropped useless `/delete-property/` - Renamed LED nodes Changes in v4: - Correctly dropped `display-subsystem` node - Dropped meaningless `pwm-fan` node - Dropped wrong `sdmmc` node - Disabled `i2c4` and `uart0` as they don't exist in the design - Format fixes Changes in v3: - Dropped non-existent node `display_subsystem` Changes in v2: - Disable display for NanoPi R4S (reference commit: 74532de460ec) - Light "sys" LED on NanoPi R4S (reference commit: 833821eeab91) Signed-off-by: Tianling Shen <cnsztl@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + 1 file changed, 1 insertion(+)