| Message ID | 20210423111037.3590242-1-brauner@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] fcntl: remove unused VALID_UPGRADE_FLAGS | expand |
On 2021-04-23 13:10, Christian Brauner wrote: > From: Christian Brauner <christian.brauner@ubuntu.com> > > We currently do not maky use of this feature and should we implement > something like this in the future it's trivial to add it back. > > Cc: Christoph Hellwig <hch@lst.de> > Cc: Aleksa Sarai <cyphar@cyphar.com> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Suggested-by: Richard Guy Briggs <rgb@redhat.com> Reviewed-by: Richard Guy Briggs <rgb@redhat.com> > --- > include/linux/fcntl.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h > index 766fcd973beb..a332e79b3207 100644 > --- a/include/linux/fcntl.h > +++ b/include/linux/fcntl.h > @@ -12,10 +12,6 @@ > FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \ > O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE) > > -/* List of all valid flags for the how->upgrade_mask argument: */ > -#define VALID_UPGRADE_FLAGS \ > - (UPGRADE_NOWRITE | UPGRADE_NOREAD) > - > /* List of all valid flags for the how->resolve argument: */ > #define VALID_RESOLVE_FLAGS \ > (RESOLVE_NO_XDEV | RESOLVE_NO_MAGICLINKS | RESOLVE_NO_SYMLINKS | \ > > base-commit: d434405aaab7d0ebc516b68a8fc4100922d7f5ef > -- > 2.27.0 > - RGB -- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
On Fri, Apr 23, 2021 at 01:10:35PM +0200, Christian Brauner wrote: > From: Christian Brauner <christian.brauner@ubuntu.com> > > We currently do not maky use of this feature and should we implement > something like this in the future it's trivial to add it back. Looks like that ->upgrade_mask field never made it into mainline? Either way removing and unused mask always seems valid, so: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h index 766fcd973beb..a332e79b3207 100644 --- a/include/linux/fcntl.h +++ b/include/linux/fcntl.h @@ -12,10 +12,6 @@ FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \ O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE) -/* List of all valid flags for the how->upgrade_mask argument: */ -#define VALID_UPGRADE_FLAGS \ - (UPGRADE_NOWRITE | UPGRADE_NOREAD) - /* List of all valid flags for the how->resolve argument: */ #define VALID_RESOLVE_FLAGS \ (RESOLVE_NO_XDEV | RESOLVE_NO_MAGICLINKS | RESOLVE_NO_SYMLINKS | \