mbox series

[v6,00/10] MPEG-2 stateless API cleanup and destaging

Message ID 20210426033522.69395-1-ezequiel@collabora.com (mailing list archive)
Headers show
Series MPEG-2 stateless API cleanup and destaging | expand

Message

Ezequiel Garcia April 26, 2021, 3:35 a.m. UTC 
Hi everyone,

Here's another round addressing Hans' feedback. More details
about this can be found in the previous cover letter [1]:

[1] https://lore.kernel.org/linux-media/20210403180756.175881-11-ezequiel@collabora.com/T/

The documentation looks good, and so does pahole,
but it's really easy to miss some detail in this series,
so we'd appreciate if more people could take a look.

v6: 
* Reorder patch "media: controls: Log MPEG-2 stateless control in .std_log"
  to avoid a new compile warning.
* Remove "reserved" field in mpeg2 sequence control, noted by Hans.
* Reorder "flags" field in mpeg2 picture control, noted by Hans.
* Typos and comments fixes, noted by Hans.

v5:
* Rename "quantization" to "quantisation", so the terminology
  matches the MPEG-2 specification.
  This is the only change in v5, compared to v4.

v4:
* Rework and clarify quantization matrices control semantics.
* Move reference buffer fields to the picture parameter control.
* Remove slice parameters control. This can be added back in the
  future if needed, but for now it's not used.
  See patch 6/9 for details.
* Destage the API.

v3:
* No API changes, just minor boilerplate fixes for the new
  controls to be properly exposed, initialized and validated.

v2:
* Fixed bad use of boolean negation in a flag, which
  was fortunately reported by 0day bot.

Ezequiel Garcia (10):
  media: uapi: mpeg2: Rename "quantization" to "quantisation"
  media: uapi: mpeg2: rework quantisation matrices semantics
  media: uapi: mpeg2: Cleanup flags
  media: uapi: mpeg2: Split sequence and picture parameters
  media: uapi: mpeg2: Move reference buffer fields
  media: hantro/cedrus: Remove unneeded slice size and slice offset
  media: uapi: mpeg2: Remove V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS
  media: uapi: Move the MPEG-2 stateless control type out of staging
  media: controls: Log MPEG-2 stateless control in .std_log
  media: uapi: move MPEG-2 stateless controls out of staging

 .../media/v4l/ext-ctrls-codec-stateless.rst   | 214 +++++++++++++++++
 .../media/v4l/ext-ctrls-codec.rst             | 217 ------------------
 .../media/v4l/pixfmt-compressed.rst           |  11 +-
 .../media/v4l/vidioc-g-ext-ctrls.rst          |  12 +
 .../media/v4l/vidioc-queryctrl.rst            |  18 +-
 .../media/videodev2.h.rst.exceptions          |   5 +-
 drivers/media/v4l2-core/v4l2-ctrls.c          | 122 +++++++---
 drivers/staging/media/hantro/hantro_drv.c     |   9 +-
 .../media/hantro/hantro_g1_mpeg2_dec.c        | 110 ++++-----
 drivers/staging/media/hantro/hantro_hw.h      |   2 +-
 drivers/staging/media/hantro/hantro_mpeg2.c   |   2 +-
 .../media/hantro/rk3399_vpu_hw_mpeg2_dec.c    | 106 ++++-----
 drivers/staging/media/sunxi/cedrus/cedrus.c   |  10 +-
 drivers/staging/media/sunxi/cedrus/cedrus.h   |   5 +-
 .../staging/media/sunxi/cedrus/cedrus_dec.c   |  10 +-
 .../staging/media/sunxi/cedrus/cedrus_mpeg2.c |  97 +++-----
 include/media/mpeg2-ctrls.h                   |  82 -------
 include/media/v4l2-ctrls.h                    |  11 +-
 include/uapi/linux/v4l2-controls.h            | 112 +++++++++
 include/uapi/linux/videodev2.h                |   7 +
 20 files changed, 610 insertions(+), 552 deletions(-)
 delete mode 100644 include/media/mpeg2-ctrls.h

Comments

Jernej Škrabec April 26, 2021, 7:36 p.m. UTC | #1 
Hi!

Dne ponedeljek, 26. april 2021 ob 05:35:12 CEST je Ezequiel Garcia napisal(a):
> Hi everyone,
> 
> Here's another round addressing Hans' feedback. More details
> about this can be found in the previous cover letter [1]:
> 
> [1] https://lore.kernel.org/linux-media/20210403180756.175881-11-ezequiel@collabora.com/T/
> 
> The documentation looks good, and so does pahole,
> but it's really easy to miss some detail in this series,
> so we'd appreciate if more people could take a look.
> 
> v6: 
> * Reorder patch "media: controls: Log MPEG-2 stateless control in .std_log"
>   to avoid a new compile warning.
> * Remove "reserved" field in mpeg2 sequence control, noted by Hans.
> * Reorder "flags" field in mpeg2 picture control, noted by Hans.
> * Typos and comments fixes, noted by Hans.

Thanks for working on this! I tested everything with Cedrus and FFmpeg and it 
works without a problem. So, whole series is:

Tested-by: Jernej Skrabec <jernej.skrabec@siol.net>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Best regards,
Jernej
Daniel Almeida April 26, 2021, 11:29 p.m. UTC | #2 
Hi Ezequiel, thanks for all your hard work on this!

On 26/04/2021 00:35, Ezequiel Garcia wrote:
 > Hi everyone,
 >
 > Here's another round addressing Hans' feedback. More details
 > about this can be found in the previous cover letter [1]:
 >
 > [1] 
https://lore.kernel.org/linux-media/20210403180756.175881-11-ezequiel@collabora.com/T/
 >
 > The documentation looks good, and so does pahole,
 > but it's really easy to miss some detail in this series,
 > so we'd appreciate if more people could take a look.
 >
 > v6:
 > * Reorder patch "media: controls: Log MPEG-2 stateless control in 
.std_log"
 >    to avoid a new compile warning.
 > * Remove "reserved" field in mpeg2 sequence control, noted by Hans.
 > * Reorder "flags" field in mpeg2 picture control, noted by Hans.
 > * Typos and comments fixes, noted by Hans.
 >

I tested this series on rk3399 (rockpi4) + upcoming gstreamer v4l2 
stateless mpeg2 decoder and it works just fine.

Tested-by: Daniel Almeida <daniel.almeida@collabora.com>


-- thanks
-- Daniel