| Message ID | 20210428142431.266879-1-david.edmondson@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | accel: kvm: clarify that extra exit data is hexadecimal | expand |
On 4/28/21 4:24 PM, David Edmondson wrote: > When dumping the extra exit data provided by KVM, make it clear that > the data is hexadecimal. > > At the same time, zero-pad the output. > > Signed-off-by: David Edmondson <david.edmondson@oracle.com> > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Le 28/04/2021 à 16:24, David Edmondson a écrit : > When dumping the extra exit data provided by KVM, make it clear that > the data is hexadecimal. > > At the same time, zero-pad the output. > > Signed-off-by: David Edmondson <david.edmondson@oracle.com> > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index b6d9f92f15..93d7cbfeaf 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -2269,7 +2269,7 @@ static int kvm_handle_internal_error(CPUState *cpu, struct kvm_run *run) > int i; > > for (i = 0; i < run->internal.ndata; ++i) { > - fprintf(stderr, "extra data[%d]: %"PRIx64"\n", > + fprintf(stderr, "extra data[%d]: 0x%016"PRIx64"\n", > i, (uint64_t)run->internal.data[i]); > } > } > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b6d9f92f15..93d7cbfeaf 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2269,7 +2269,7 @@ static int kvm_handle_internal_error(CPUState *cpu, struct kvm_run *run) int i; for (i = 0; i < run->internal.ndata; ++i) { - fprintf(stderr, "extra data[%d]: %"PRIx64"\n", + fprintf(stderr, "extra data[%d]: 0x%016"PRIx64"\n", i, (uint64_t)run->internal.data[i]); } }
When dumping the extra exit data provided by KVM, make it clear that the data is hexadecimal. At the same time, zero-pad the output. Signed-off-by: David Edmondson <david.edmondson@oracle.com> --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)