| Message ID | cover.dc9133eee56aa67653455928e4de2162e344ce4d.1618310618.git-series.a.fatoum@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | watchdog: f71808e_wdt: migrate to new kernel API | expand |
On 13.04.2021 12:46:43, Ahmad Fatoum wrote: > This series migrates the driver to the new kernel watchdog API and > then to the driver model. > > Main feedback from Guenther on v2 was that I need to split it up to > enable review. I have done so by removing the extra refactoring for > now and focused on the functional changes described above. The diff > is now much better readable. > > I tested it on a f81866. Is there a chance to get this series applied and mainline? Is there anything that's blocking it? regards, Marc
On 5/3/21 6:09 AM, Marc Kleine-Budde wrote: > On 13.04.2021 12:46:43, Ahmad Fatoum wrote: >> This series migrates the driver to the new kernel watchdog API and >> then to the driver model. >> >> Main feedback from Guenther on v2 was that I need to split it up to >> enable review. I have done so by removing the extra refactoring for >> now and focused on the functional changes described above. The diff >> is now much better readable. >> >> I tested it on a f81866. > > Is there a chance to get this series applied and mainline? Is there > anything that's blocking it? > Yes, time to review. Sorry, I am way backlogged with code reviews. Guenter
On 03.05.2021 06:33:21, Guenter Roeck wrote: > On 5/3/21 6:09 AM, Marc Kleine-Budde wrote: > > On 13.04.2021 12:46:43, Ahmad Fatoum wrote: > >> This series migrates the driver to the new kernel watchdog API and > >> then to the driver model. > >> > >> Main feedback from Guenther on v2 was that I need to split it up to > >> enable review. I have done so by removing the extra refactoring for > >> now and focused on the functional changes described above. The diff > >> is now much better readable. > >> > >> I tested it on a f81866. > > > > Is there a chance to get this series applied and mainline? Is there > > anything that's blocking it? > > > > Yes, time to review. Sorry, I am way backlogged with code reviews. That sounds familiar to me :/ But on the other hand I have a co-worker that's interested in watchdogs :) He'll try to do some reviews. regards, Marc
This series migrates the driver to the new kernel watchdog API and then to the driver model. Main feedback from Guenther on v2 was that I need to split it up to enable review. I have done so by removing the extra refactoring for now and focused on the functional changes described above. The diff is now much better readable. I tested it on a f81866. v3 -> RESEND: https://lore.kernel.org/linux-watchdog/cover.dedd9f1159389b0a438076ef5e5a46aded186463.1612457906.git-series.a.fatoum@pengutronix.de/#t Didn't generate any feedback over 2 months. Resending for exposure. v2 -> v3: https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/ - factored out identifier renaming again for easier review - reordered commits - removed refactoring that can go in later. Focusing now on kernel watchdog API and platform device/driver migration - removed platform_device_id and changed code to match by name v1 -> v2: https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/ - reworked to platform device/driver pair (Guenther) - squashed identifier renaming into the patches that touch the respective lines anyway - fixed checkpatch.pl nitpicks (Guenther) - fixed locally used variable declared without static (0-day) - fixed unneded line break due to old line limit (Guenther) - renamed struct fintek_wdog_data to struct fintek_wdt Ahmad Fatoum (3): watchdog: f71808e_wdt: rename variant-independent identifiers appropriately watchdog: f71808e_wdt: migrate to new kernel watchdog API watchdog: f71808e_wdt: refactor to platform device/driver pair drivers/watchdog/Kconfig | 1 +- drivers/watchdog/f71808e_wdt.c | 450 +++++++--------------------------- 2 files changed, 100 insertions(+), 351 deletions(-) base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac