| Message ID | 20201211012317.3722214-1-morbo@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5f443e424efab56baa8021da04878f88eb0815d4 |
| Headers | show |
| Series | [v2] selftests: kvm: remove reassignment of non-absolute variables | expand |
On Thu, Dec 10, 2020 at 7:58 PM Bill Wendling <morbo@google.com> wrote: > > Clang's integrated assembler does not allow symbols with non-absolute > values to be reassigned. Modify the interrupt entry loop macro to be > compatible with IAS by using a label and an offset. > > Cc: Jian Cai <caij2003@gmail.com> > Signed-off-by: Bill Wendling <morbo@google.com> > References: https://lore.kernel.org/lkml/20200714233024.1789985-1-caij2003@gmail.com/ Reviewed-by: Jim Mattson <jmattson@google.com>
On 03/05/21 20:37, Jim Mattson wrote: > On Thu, Dec 10, 2020 at 7:58 PM Bill Wendling <morbo@google.com> wrote: >> >> Clang's integrated assembler does not allow symbols with non-absolute >> values to be reassigned. Modify the interrupt entry loop macro to be >> compatible with IAS by using a label and an offset. >> >> Cc: Jian Cai <caij2003@gmail.com> >> Signed-off-by: Bill Wendling <morbo@google.com> >> References: https://lore.kernel.org/lkml/20200714233024.1789985-1-caij2003@gmail.com/ > Reviewed-by: Jim Mattson <jmattson@google.com> > Queued, thanks. Paolo
diff --git a/tools/testing/selftests/kvm/lib/x86_64/handlers.S b/tools/testing/selftests/kvm/lib/x86_64/handlers.S index aaf7bc7d2ce1..7629819734af 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/handlers.S +++ b/tools/testing/selftests/kvm/lib/x86_64/handlers.S @@ -54,9 +54,9 @@ idt_handlers: .align 8 /* Fetch current address and append it to idt_handlers. */ - current_handler = . +666 : .pushsection .rodata -.quad current_handler + .quad 666b .popsection .if ! \has_error
Clang's integrated assembler does not allow symbols with non-absolute values to be reassigned. Modify the interrupt entry loop macro to be compatible with IAS by using a label and an offset. Cc: Jian Cai <caij2003@gmail.com> Signed-off-by: Bill Wendling <morbo@google.com> References: https://lore.kernel.org/lkml/20200714233024.1789985-1-caij2003@gmail.com/ --- tools/testing/selftests/kvm/lib/x86_64/handlers.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)